search

Heatmanofurioso / ngx-avatars

Spiritual successor of HaithemMosbahi's ngx-avatar
MIT License
16 stars 11 forks source link

Repair build #21

Closed baxyz closed 2 years ago

baxyz commented 2 years ago

This PR aims to repair the build of this lib.

It closes #20

Tasks:

Note: it is compatible with node 17 with an extra option:

NODE_OPTIONS="--openssl-legacy-provider" yarn build
Heatmanofurioso commented 2 years ago

Hi @baxyz

First off, sorry for taking a while in responding to #20 Thanks for the initiative in adding this PR addressing the issue you raised.

I'm going to test this tomorrow as the code looks good. If everything works nicely after that, I'll merge and release the fix still tomorrow

Heatmanofurioso commented 2 years ago

@baxyz Could you please merge develop into your branch? These was a deprecation issue with TravisCI that I had to fix in order for the pipelines to work again.

As it is, the CI pipelines won't pass on your branch

baxyz commented 2 years ago

@baxyz Could you please merge develop into your branch? These was a deprecation issue with TravisCI that I had to fix in order for the pipelines to work again.

Done 😉.