Parser should not require win32_ext.h

GoogleCodeExporter commented 8 years ago

It's bad for a few reasons:
  (1) it looks like it copypaste from the Win32 SDK headers, which isn't compatible with our licensing. 
  (2) it needs to be present on the input path or working directory whenever the parser is invoked, which is cumbersome.

   We shouldn't need this file at all. If the contents are important for the parser to establish dependencies, they should be scraped out of the real Win32 SDK headers on the build machine, possibly using a technique that scrapes only the specified types rather than every type in a header to allow for the fact that the Win32 headers are quite massive and would produce a lot of bloat in the XIDL.
  If we just need these because we need mappings for the relevant defines (seems unlikely), we can manually provide the mapped code. We don't need to generate everything.

Original issue reported on code.google.com by josh.petrie on 16 Nov 2010 at 4:53

Merged into: #735

GoogleCodeExporter commented 8 years ago

win32_ext.h is not copy paste but has been written by hand. Defines shouldn't 
have any legal issues.

The only part that was copy/paste are the structures. I will move them in a XML 
declaration.

Original comment by alx.xo...@gmail.com on 16 Nov 2010 at 4:04

GoogleCodeExporter commented 8 years ago

Also, 2) Is fixed, as win32_ext is now integrated as an embedded resource.

Original comment by alx.xo...@gmail.com on 16 Nov 2010 at 4:11

GoogleCodeExporter commented 8 years ago

Original comment by alx.xo...@gmail.com on 16 Nov 2010 at 4:13

Changed state: Duplicate

HeavenWu / slimdx

Parser should not require win32_ext.h #732