search

Hebei-Studios / Tang-County-Issues

Community issue tracker, discussions for new features and enhancements for Tang County.
https://www.roblox.com/groups/12348193/Hebei-Studios#!/about
Creative Commons Attribution Share Alike 4.0 International
0 stars 0 forks source link

Infinite decimals in money #15

Closed kinggy2929 closed 3 weeks ago

kinggy2929 commented 4 weeks ago

Description

After selling a car you gain infinite decimal places in your money stat. If you buy a new car, the decimals also change with it. It happens anywhere from private servers to public servers. There was no log output for the issue

Reproduction Steps

  1. Sell a car
  2. Buy another car
  3. Sell the car again

Screenshots & Videos

https://github.com/Hebei-Studios/Tang-County-Issues/assets/172155244/dcba88bc-dc2f-451c-b935-3d7bdb3e4c17

image_2024-06-08_195440423

Logs

image_2024-06-08_195639355

Operating System

Computer, Mobile

Additional Information

No response

Checklist

iceeburr commented 4 weeks ago

Should be fixed in the dev place. Will monitor further and try to reproduce it again, will push to main if no further issues arise. Will put it on monitoring for a few days, if there are no reports will close as resolved 👍🏻

iceeburr commented 3 weeks ago

Pushed to main game. Hope it won't have breaking changes. Basically added math.round() when selling a car. To fix for users that got their data store infected I also did rounding when the player's money value is set right after they join. Once they leave it should save with the rounded value as well.