Hebei-Studios / Tang-County-Issues

Community issue tracker, discussions for new features and enhancements for Tang County.
https://www.roblox.com/groups/12348193/Hebei-Studios#!/about
Creative Commons Attribution Share Alike 4.0 International
0 stars 0 forks source link

Kohl Admin triggers invalid command messages when typing in chat #6

Open iceeburr opened 3 months ago

iceeburr commented 3 months ago

Description

When you write any message in the game chat it will trigger a command in the Kohl Admin module. Because the user doesn't have permission to use it it will display a big annoying message saying the user doesn't have permission to use it.

Reproduction Steps

  1. Join the game and write anything in chat
  2. Kohl Admin thinks you typed a command
  3. A big annoying message appears

Screenshots & Videos

image

Logs

No response

Operating System

No response

Additional Information

Reference Issue on Discord

Checklist

iceeburr commented 3 months ago

Personally had a similar issue during a roleplay session in the official Tang County RP server. Certain keybinds also trigger flying for some reason and it's very annoying when you get in such situation.

Might need further discussion to replace this admin module with something better. It has a lot of user reports in other games including backdoors and sketchy practices.

Shinedown204 commented 3 months ago

Kohl Admin is an admin system that's widely used, if there's a better alternative (perhaps 'HD Admin', which is another open-sourced admin system), we can utilize that. I would prefer not to create our own admin system to save time and resources.

iceeburr commented 3 months ago

Personally I'd prefer a heavily modified version of HD Admin. I've had some experience with it before. Should be relatively easy to switch in the future as we are rewriting everything. I guess this will go to V4 for now. We can get back on it later.

Custom commands are also so much easier to do with HD. It's just better and the maintainer is more adequate in my opinion. Though the project is dead, it has been a "standard" for many years and proves its stability. Of course we will look into many other open-source libraries, we don't necessarily need something specific. Writing something from scratch is indeed time consuming.

zharvuiys commented 3 months ago

I would suggest making an admin panel from scratch, with custom commands (ofc this would take a while, so maybe you could integrate HD into a custom panel(?). Maybe something similar to Commander 4 (images below).

image image image image

I was trying to give our new mod, @winneristome, moderator perms today in-game, but the moderator rank doesn't even have the needed commands, like ban for example, so I had to give base admin instead. I'm unsure how HD works as I've never used it, but I feel like a custom panel, with custom permissions and all, that we could build off of in the future, would be best.

I understand it would be time consuming, and take up a lot of resources, but this is my opinion on the matter.

Shinedown204 commented 3 months ago

We'll likely implement HD admin, as for an admin panel, that's something that can be considered at a later date; after the rewrite. It's a good idea.

zharvuiys commented 3 months ago

Winneristome just gave an interesting idea. If we do have an admin panel in the future, we should have a 'mod call/staff call/alerts/assistance' tab (something along those lines).

People could type into a menu that they need a staff member for something (maybe there's an exploiter, a troll ruining it for everyone, or something else), and it would be sent to a tab on the panel, which all staff members, even in other servers, can see. Staff could click on these notifications, and they'd be sent to the server the call came from, so they can help.

winneristome commented 3 months ago

As stated above, I think a modcall or a !help system in game would be a good upgrade since a lot of people are really frustrated and end up leaving due to other players gltiching them or harassing them which is not acceptable or even exploiters ruining the game. I think every player should have a positive opinion on the game and must play the game often. If we clear out or eliminate all the exploiters, abusers and other rule-breaking indivuals it would bring a positive feedback to the mod and the admin team and also the game.