Closed josephcoombe closed 6 years ago
edit: I see it's already recorded here: https://github.com/HebiRobotics/HEBI-ROS/issues/32
Opening PR for bug we ran into (and Matt fixed on my machine) while up at HEBI.
Right now, a service request where the user provides a families array of length > 1 AND a names array of length > 1 will not be handled correctly.
e.g: This service request from a Python client node will cause the hebiros node try and create a group with 9 modules (all combinations):
set_hebi_group = rospy.ServiceProxy('/hebiros/add_group_from_names', AddGroupFromNamesSrv) set_hebi_group("group_name",["A", "B", "C"],["FAM1", "FAM2", "FAM3"])
This is a possible fix that supports cases where user provides:
Will still break if user makes a service call with families array length > 1, names array length > 1 and families array length != names array length.
e.g: set_hebi_group = rospy.ServiceProxy('/hebiros/add_group_from_names', AddGroupFromNamesSrv) set_hebi_group("group_name",["A", "B", "C"],["FAM1", "FAM3"])
set_hebi_group = rospy.ServiceProxy('/hebiros/add_group_from_names', AddGroupFromNamesSrv) set_hebi_group("group_name",["A", "B", "C"],["FAM1", "FAM3"])
Fixed in /develop in other PR
edit: I see it's already recorded here: https://github.com/HebiRobotics/HEBI-ROS/issues/32
Opening PR for bug we ran into (and Matt fixed on my machine) while up at HEBI.
Right now, a service request where the user provides a families array of length > 1 AND a names array of length > 1 will not be handled correctly.
e.g: This service request from a Python client node will cause the hebiros node try and create a group with 9 modules (all combinations):
set_hebi_group = rospy.ServiceProxy('/hebiros/add_group_from_names', AddGroupFromNamesSrv) set_hebi_group("group_name",["A", "B", "C"],["FAM1", "FAM2", "FAM3"])
This is a possible fix that supports cases where user provides:
Will still break if user makes a service call with families array length > 1, names array length > 1 and families array length != names array length.
e.g:
set_hebi_group = rospy.ServiceProxy('/hebiros/add_group_from_names', AddGroupFromNamesSrv) set_hebi_group("group_name",["A", "B", "C"],["FAM1", "FAM3"])