Hecatoncheir / espresso_light_theme

Espresso Light theme for IDE
https://plugins.jetbrains.com/plugin/12317-espresso-light-theme
MIT License
9 stars 2 forks source link

Tree expand collapse icons are not visible on selected line #3

Closed gayanper closed 3 years ago

gayanper commented 4 years ago

On Windows 10 when selecting the tree item cause the expand collapse icon not to be visible due to the selection background and the icon both having the color as white.

rkrv commented 4 years ago

👋 I'm having the same issue:

image image

Hecatoncheir commented 4 years ago

I do not know what I can use for fix that:

Annotation 2020-09-02 235339

Maybe later, when it will be possible...

rkrv commented 4 years ago

@Hecatoncheir I had it traced back to the Espresso Light theme using IntelliJ Light as the base for icons.

image

I found that you should be able to replace default icons with custom icons in a theme, there is a readme here: https://jetbrains.org/intellij/sdk/docs/reference_guide/ui_themes/themes_customize.html

The icon names from the IntelliJ Light theme are: arrowDown_dark, arrowDown_white, treeDownArrow, (and could be others similar - I haven't been able to identify exactly which).

Default icons on osx live under /Applications/PHPStorm/Contents/lib/icons.jar.

Hope any of this helps.

Hecatoncheir commented 3 years ago

I use Tree.iconColor:

  "icons": {
    "ColorPalette": {
      "Tree.iconColor": "#325a7d",

But expand/collapse icons work perfect only if "dark" property set true:

Screenshot 2021-02-16 222616

Not perfect theme system...

Hecatoncheir commented 3 years ago

Maybe like this(1.2.0 version): gnome-shell-screenshot-0OFD00

rkrv commented 3 years ago

Just got the update, looks sweet!

Hecatoncheir commented 3 years ago

Thx.