HectorTorresE / personal-portfolio

0 stars 0 forks source link

Hector Torres: Peer to peer code review #6

Open ForHemer opened 2 years ago

ForHemer commented 2 years ago

Congratulations :clap: on your project, you did very well :100: , but there are a few changes to bring on it:

@kinginthenorthcodez: Use less chaining in your resource or assets to optimize your website. As per the reviewer

@miftah1991: Everything is perfect in Hector's project, he did a good job but we suggest the below optional changes which will make his project more better. 1. Description of PR 2. check for linter errors locally and if there is no error then push the code 3. always try to link the src image from the root because later if your project is more complicated and you want to move some pages in a folder then it will be very difficult to manage it.

@ForHemer: Wrap your design inside a viewport like @media (min-width: 992px) instead to put it as you did on your CSS file.