size/shape of book frame

[ian-crowther]

https://www.dropbox.com/s/mxzajg51mz5keth/Screenshot%202018-09-30%2013.45.07.png?dl=0

Looks like on this branch, the book frame extends all the way to the bottom of the viewport, but it should be offset as on the main V2.

[EricWVGG]

I can restore that behavior, but I warn you guys that it's never going to work very well.

[ian-crowther]

Would you mind explaining in a little more detail? Maybe there's another way to solve the issue.

[EricWVGG]

It's difficult to explain in detail, but basically what you're trying to do is hijack the browser's scrolling behavior, and that always, always winds up being janky.

[ian-crowther]

Would it be possible to simulate the same design some other way? Like making the purple sheet at the top of the screen position: sticky and just using it to cover the content of the frame? Or to include a single element at the bottom of the iframe that acts as the bottom of the frame itself?

I think it’s at least marginally important to solve this somehow - the frame is meant to suggest an abstracted book within the viewport, and if it bleeds off the bottom of the viewport, that’s less likely to be clear.

On October 1, 2018 at 1:11:18 PM, Eric Jacobsen (notifications@github.com) wrote:

It's difficult to explain in detail, but basically what you're trying to do is hijack the browser's scrolling behavior, and that always, always winds up being janky.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Hederis/hederis.github.io/issues/15#issuecomment-425987300, or mute the thread https://github.com/notifications/unsubscribe-auth/AD9FfMc_Lb-aL5VyC0ylpL5TIZR2b0r_ks5ugky2gaJpZM4XBEtE .

[EricWVGG]

yeah, like I could add a mask at the bottom… I don't really understand the metaphor, though; pages don't scroll, they flip. Unless you're on a good e-reader and replace flipping with scrolling — and we've already got scrolling. That's just how digital screens work.

[EricWVGG]

re: Ian “Eric, I think I may have answered your question from Slack a few days back incorrectly. There should be a border around the book frame but the appearance of it on Nellie's branch just wasn't quite right - I had thought that appearance was coming from an iframe border inadequately hidden. I added an issue for @nelliemckesson to address that.”

[ian-crowther]

For better or worse, the idea is to kind of suggest the form of a "book" that isn't quite specific to a physical book or an e-reader. I agree that it's not the most rigorous visual metaphor.

[EricWVGG]

If everyone can agree to keep the length of the paragraphs under control, we could just make the animated book bigger and "flip" through that.

[ian-crowther]

That was proposed during design and Erica and @nelliemckesson were too concerned that it would look like Hederis' product was a physical book to purchase.

[EricWVGG]

restored

[nelliemckesson]

@EricWVGG @ian-crowther Just want to check in on where we landed on this. In the v2-eric branch, it looks like the bookframe still stretches the full window height. Are we sticking with that behavior?

[EricWVGG]

Yup I forgot to push out a branch. Take another look.

[nelliemckesson]

@EricWVGG ah cool, thanks! I think you need to add one more file to the commit: scroll_lock.js (seems to be missing from the repo).