search

HedvigS / SH.misc

GNU General Public License v3.0
0 stars 0 forks source link

adding south-up functions #5

Open HedvigS opened 9 months ago

HedvigS commented 9 months ago

I think we should find a way to workin the functions over at skalyan91/south-up here. That way they'd be in a package people can install and run. What do you think @skalyan91 ?

skalyan91 commented 9 months ago

I guess it would work, as long as we distribute the .qs files along with the package, and omit the code for creating those files. It would be a mess if we had to rely on obsolete versions of dependencies (as we’re currently doing with our use of groundhog)—fortunately those are only needed for creating the .qs files.

But I like the idea of including the south-up functions in our package!

HedvigS commented 9 months ago

Cool!

I'm thinking we need to scale back a bit, maybe there's a way of simplifying the qs file structure.. I have some ideas. If you work on #1 i'll make a branch for south-up and we can review each other in... I don't know. No hurry right? :D

skalyan91 commented 9 months ago

A week, maybe?

HedvigS commented 9 months ago

A week, maybe?

Oh wow, yeah maybe. I'm teaching in Uppsala next week so I'm prepping. But... I do enjoy this :)!. We'll see.

skalyan91 commented 9 months ago

Like you said, no hurry :).

HedvigS commented 2 months ago

@skalyan91 I've added a beta-version of a function that does a baseman with just EEZ, not the elevation information.