Build printable version without background

[tomaas-zeman]

Addresses https://github.com/Heegu-sama/Homm3BG/issues/546

I didn't touch the release flow though. There seemed to be multiple steps related to generating the current printable version so I didn't want to unecessarily duplicate that part

[tomaas-zeman]

3. Update the table in readme to include the economy printable build link. That way, an always up-to-date file will be easy to download for everyone.

Is the table manually maintained or somehow automatically generated upon release?

[qwrtln]

3. Update the table in readme to include the economy printable build link. That way, an always up-to-date file will be easy to download for everyone.

Is the table manually maintained or somehow automatically generated upon release?

The table is just HTML code in README.md. The links are updated automatically upon every merge to master. Or, to be more exact, the links are the same, but their contents update.

[qwrtln]

I can see you already learned to use po4a, that's very good. Please update the translations for the title_page, as it will be trivial for you, and we won't have to bother the translators with this. It boils down to deleting the fuzzy commented-out string, and updating its respective msgstr entry to reflect the new contents.

[tomaas-zeman]

I can see you already learned to use po4a, that's very good. Please update the translations for the title_page, as it will be trivial for you, and we won't have to bother the translators with this. It boils down to deleting the fuzzy commented-out string, and updating its respective msgstr entry to reflect the new contents.

"Learned" is a strong word :D I'm not sure what you mean by fuzzy but I'll take a look and ask if anything is unclear

[DarthGandalf]

I think the "no" variables are confusing. Maybe make it something like "include background" instead, with default to true?

[DarthGandalf]

Why is this specifically tied to printable? Wouldn't it be easier to add an independent switch?

[tomaas-zeman]

Why is this specifically tied to printable? Wouldn't it be easier to add an independent switch?

Because this is really meant to be used only to print it hence you'd like to use the features that regular printable can give you

[qwrtln]

po4a check

[qwrtln]

po4a check

Argh, doesn't work with forks: https://github.com/Heegu-sama/Homm3BG/actions/runs/9353999324/job/25745816276

[tomaas-zeman]

po4a check

Argh, doesn't work with forks: https://github.com/Heegu-sama/Homm3BG/actions/runs/9353999324/job/25745816276

If you give me permissions, I can commit the branch here and create a new PR

[qwrtln]

po4a check

Argh, doesn't work with forks: https://github.com/Heegu-sama/Homm3BG/actions/runs/9353999324/job/25745816276

If you give me permissions, I can commit the branch here and create a new PR

No need for now, it does the same thing as the PR check. The only difference is that it posts a nice diff as a comment if there's an error.

[qwrtln]

@tomaas-zeman Are you able to download the artifacts from the workflow? I'm checking them now, but the download speed is painfully slow (~50KB/s).

[qwrtln]

@tomaas-zeman Are you able to download the artifacts from the workflow? I'm checking them now, but the download speed is painfully slow (~50KB/s).

Never mind, I checked the files, they look good. Please revert the temporary workflow change, we're good to go 🚀 I'll approve once #552 is merged.

[tomaas-zeman]

@tomaas-zeman Are you able to download the artifacts from the workflow? I'm checking them now, but the download speed is painfully slow (~50KB/s).

I get 404 but I'm not sure if it's because those artifacts expired or I don't have access.

I tried only locally

[qwrtln]

@tomaas-zeman Are you able to download the artifacts from the workflow? I'm checking them now, but the download speed is painfully slow (~50KB/s).

I get 404 but I'm not sure if it's because those artifacts expired or I don't have access.

I tried only locally

If you're using the link you put in the readme table, it won't work, as the builds don't exist yet. You should download the files from the workflow summary: https://github.com/Heegu-sama/Homm3BG/actions/runs/9354033333

[qwrtln]

Oh, one more thing. It's not a must, but can you update the tools/release.sh script to include the economy printable build? So far it was me who built the release files, it will make my life (or whoever does the build for the next release) a little easier.

[qwrtln]

552 was merged, please rebase and let's merge this.

[tomaas-zeman]

552 was merged, please rebase and let's merge this.

Should be ready to merge. Please double-check it, I had ton of conflicts

[tomaas-zeman]

@qwrtln it seems I need one more approval. Do you know who could help?

[qwrtln]

@qwrtln it seems I need one more approval. Do you know who could help?

Yes, the repo owner. Please wait for his approval. You'll get it eventually.