search

Heegu-sama / Homm3BG

Repository for rewriting the rule book.
77 stars 14 forks source link

[CS] Initial Czech language commit #557

Closed tomaas-zeman closed 2 weeks ago

qwrtln commented 3 weeks ago

Please give me the text you'd like in place of "RULE BOOK REWRITE" on the cover in Czech. I'll create a suitable image for you.

tomaas-zeman commented 3 weeks ago

Please give me the text you'd like in place of "RULE BOOK REWRITE" on the cover in Czech. I'll create a suitable image for you.

I think you can put "Revidovaná pravidla" there. Sadly, there isn't consistency between translations.

BTW, why is it an image and not a text?

qwrtln commented 3 weeks ago

Please give me the text you'd like in place of "RULE BOOK REWRITE" on the cover in Czech. I'll create a suitable image for you.

I think you can put "Revidovaná pravidla" there. Sadly, there isn't consistency between translations.

BTW, why is it an image and not a text?

Because creating a good-looking text with a good-loking drop shadow in LaTeX is a big PITA.

qwrtln commented 3 weeks ago

Changing the workflows requires updating them in the settings every time the change is made. Please, don't wait with the change, and do it once in a single place. Let's respect each other's time. Get rid of the leftovers in #555.

qwrtln commented 3 weeks ago

This goes to translations/assets/cs cover_subtitle

tomaas-zeman commented 3 weeks ago

Changing the workflows requires updating them in the settings every time the change is made. Please, don't wait with the change, and do it once in a single place. Let's respect each other's time. Get rid of the leftovers in #555.

Got it, it's done

DarthGandalf commented 2 weeks ago

We're using LuaLaTeX only for Cyrillic languages. The German version with it is an error.

For Cyrillic that's a necessity, but for Latin it's more a preference. The default LaTeX font was producing very bad result for headers in Russian, so we switched to TTF font which didn't have such issues, but that requires Lua. Really there's nothing preventing using Lua for other languages as well.

tomaas-zeman commented 2 weeks ago

Oops, there's another job in the workflow which checks if the number of pages is correct. Please add it for your language.

Sorry, I missed that one. Fixed

qwrtln commented 2 weeks ago

Oops, there's another job in the workflow which checks if the number of pages is correct. Please add it for your language.

Sorry, I missed that one. Fixed

Oops, there's another job in the workflow which checks if the number of pages is correct. Please add it for your language.

Sorry, I missed that one. Fixed

Perfect. @Heegu-sama, we need your help again with adding Czech to the mandatory checks.

tomaas-zeman commented 2 weeks ago

Sorry, until the checks are mandatory, I'm blocking the PR. In every language there should be 53 pages.

This is because of czech babel again. Some of the layouts got broken because words are differently wrapped a paragraphs have more lines. I can hotfix this but I'm slightly afraid this could pop up again in the future.

Screenshot 2024-06-06 at 21 56 19

In this case the issue is valid because it really looks ugly. But what if, due to language nature, we need more pages in Czech to explain the rules?

The way the layout is build now is certainly to make it look really nice but it's fragile at the same time. I encountered this problem while translating the components - some Czech expressions didn't fit into narrow space, it was wrapper to one more line and the whole layout got completely broken.

Example:

English: Neutral Unit Card
Czech:   Karta Neutrální Jednotky

In order to fit into the layout, I had to change the translation to:

Czech:   Neutrální Jednotka
English: Neutral Unit

Which just isn't the same and compromises will have to be made in many places.

qwrtln commented 2 weeks ago

Sorry, until the checks are mandatory, I'm blocking the PR. In every language there should be 53 pages.

what if, due to language nature, we need more pages in Czech to explain the rules?

Literally every other translator asked exactly the same question. And guess what: in every language, the document has 53 pages. When in doubt, refer to the original, which also maintains the same number of pages and the same layout for every language.

tomaas-zeman commented 2 weeks ago

Sorry, until the checks are mandatory, I'm blocking the PR. In every language there should be 53 pages.

what if, due to language nature, we need more pages in Czech to explain the rules?

Literally every other translator asked exactly the same question. And guess what: in every language, the document has 53 pages. When in doubt, refer to the original, which also maintains the same number of pages and the same layout for every language.

I'm saying that fixing three pages now is easy. I'm not sure how many changes had to be made in other languages but I just don't want to end up in situation where a new chapter is added and czech will not pass this test. This could be a pain for all future contributors.

I have no idea how often that happened in past with other languages so I'm obviously very cautious about it

qwrtln commented 2 weeks ago

I'm saying that fixing three pages now is easy. I'm not sure how many changes had to be made in other languages but I just don't want to end up in situation where a new chapter is added and czech will not pass this test. This could be a pain for all future contributors.

Believe me, translating crews in every language worked really hard on this. The problem is not unique to Czech language, every translation carries that risk.

qwrtln commented 2 weeks ago

As a workaround, I guess you could use both Czech and English with babel for now?

DarthGandalf commented 2 weeks ago

We don't add new chapters very often. But I agree, the layout is pretty fragile, but that's why there are automated checks here for every PR

tomaas-zeman commented 2 weeks ago

As a workaround, I guess you could use both Czech and English with babel for now?

Yeah, that's exactly what I'm trying now but it doesn't seem to help much

tomaas-zeman commented 2 weeks ago

Believe me, translating crews in every language worked really hard on this.

I don't doubt that :) My only concern was to not create annoying situation for others in future contribution if that was not clear

DarthGandalf commented 2 weeks ago

As a workaround you can add \vspace{-10em} to places where layout broke, in the "translated" .po files, even with English text for now

qwrtln commented 2 weeks ago

As a workaround you can add \vspace{-10em} to places where layout broke, in the "translated" .po files, even with English text for now

I hate it, but it's probably the easiest solution for now xD

tomaas-zeman commented 2 weeks ago

Concrete example. Even with multilanguage babel, the page doesn't get better :/

Screenshot 2024-06-06 at 22 18 13
qwrtln commented 2 weeks ago

I don't doubt that :) My only concern was to not create annoying situation for others in future contribution if that was not clear

Yeah OK, I should have communicated it more effectively or more politely, sorry. But the sad reality is that if a translation breaks the layout, then the translator hasn't done a very good job and needs to improve their work. Most translators just want to do it once and be done with it. It will be your job, the CEO of Czech translation, to keep them aware.

...which made me realize that the CODEOWNERS file was not updated with the Czech language. Please do it now.

tomaas-zeman commented 2 weeks ago

Is there a way to force english babel to untranslated pages? Maybe the multilang doesn't work that well by default

qwrtln commented 2 weeks ago

Is there a way to force english babel to untranslated pages? Maybe the multilang doesn't work that well by default

Dump multilang, use vspace

qwrtln commented 2 weeks ago

Concrete example. Even with multilanguage babel, the page doesn't get better :/

Screenshot 2024-06-06 at 22 18 13

Oh, it's clear and simple. The subsection spacing in Czech is bigger than in English. That's the problem. The answer for now is definitely vspaces.

DarthGandalf commented 2 weeks ago

example of this workaround: https://github.com/Heegu-sama/Homm3BG/blob/28072d891b8df4a8df85f1912a59d62219a0110a/translations/components.tex/es.po#L34

tomaas-zeman commented 2 weeks ago

Yeah OK, I should have communicated it more effectively or more politely, sorry.

No worries. Same apology from my side if I came across impolite.

But the sad reality is that if a translation breaks the layout, then the translator hasn't done a very good job and needs to improve their work.

I see. If that's the world translators live in, I guess I'll go with the flow and try to do it so it doesn't break :D

...which made me realize that the CODEOWNERS file was not updated with the Czech language. Please do it now.

Sure

tomaas-zeman commented 2 weeks ago

Oh, it's clear and simple. The subsection spacing in Czech is bigger than in English. That's the problem. The answer for now is definitely vspaces.

You're right! I was so focused on the different word wrap that I didn't notice that

DarthGandalf commented 2 weeks ago

Unknown owner on line 50: make sure @tomaas-zeman exists and has write access to the repository

hmm

tomaas-zeman commented 2 weeks ago

Unknown owner on line 50: make sure @tomaas-zeman exists and has write access to the repository

hmm

But it doesn't seem to be mandatory for this PR 🤷