Test unforgiving dread knight

[qwrtln]

The goal is to disallow dread knight shrinking, which allowed some overflows to pass page checks.

before|after

[DarthGandalf]

Image please

[qwrtln]

Image please

It's WIP, sorry

[qwrtln]

Verbose translations will no longer be able to bypass the checks.

[qwrtln]

Agreed, but currently impossible without changing original text.

11 Jun 2024 13:46:48 Tomas Zeman @.***>:

@.**** commented on this pull request.

---

In sections/combat.tex[https://github.com/Heegu-sama/Homm3BG/pull/579#discussion_r1634716867]:

-\clearpage +\begin{center}

• \includegraphics[width=0.97\linewidth]{\art/dread_knight.jpg}

Not a big deal but to my surprise, I was able to squeeze Czech translation to a point where the Dread knight can be at full width, which looks slightly better. Maybe we could do the same with other languages

Screenshot.2024-06-11.at.13.45.35.png (view on web)[https://github.com/Heegu-sama/Homm3BG/assets/1928291/28025518-4545-49b9-8297-8b3c8422191d]

— Reply to this email directly, view it on GitHub[https://github.com/Heegu-sama/Homm3BG/pull/579#pullrequestreview-2110198270], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABKZ5O6SBVBDEXPWP5UU7MTZG3PSFAVCNFSM6AAAAABJDWKODKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJQGE4TQMRXGA]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/ABKZ5OYD5B2MIPMAR5KIDDTZG3PSFA5CNFSM6AAAAABJDWKODKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT5Y4I74.gif]

[qwrtln]

I have no idea why, but German yields different results locally and in the workflow. Apart from the word "ends" carried over to the next column, everything else seems identical.

@DarthGandalf @tomaas-zeman

[tomaas-zeman]

I have no idea why, but German yields different results locally and in the workflow. Apart from the word "ends" carried over to the next column, everything else seems identical.

Isnt it because workflow has lua enabled and locally its disabled?

https://github.com/Heegu-sama/Homm3BG/blob/main/.github/workflows/build-and-publish-rule-book.yaml#L39 https://github.com/Heegu-sama/Homm3BG/blob/main/tools/build.sh#L11

[qwrtln]

I have no idea why, but German yields different results locally and in the workflow. Apart from the word "ends" carried over to the next column, everything else seems identical.

Isnt it because workflow has lua enabled and locally its disabled?

I have no idea why, but German yields different results locally and in the workflow. Apart from the word "ends" carried over to the next column, everything else seems identical.

Isnt it because workflow has lua enabled and locally its disabled?

Could be. I changed the workflow locally but haven't pushed yet. You can see that lua performs hyphenation in different places.

[qwrtln]

po4a check

[github-actions[bot]]

⚠️ po4a would edit the following files:

 M translations/combat.tex/es.po

Click to see details 🧐

```diff diff --git a/translations/combat.tex/es.po b/translations/combat.tex/es.po index b675e7f..a7f9e38 100644 --- a/translations/combat.tex/es.po +++ b/translations/combat.tex/es.po @@ -486,8 +486,7 @@ msgid "" msgstr "" "\\vspace{-10em}\\phantom{fuzzy - remove this line once text is fixed}\n" "\\subsection*{\\pagetarget{Endcombat}{Fin del Combate}}\n" -"\\vspace*{\\lang_header_adjustment}" -"El combate termina inmediatamente si todas las unidades de un bando son derrotadas.\n" +"\\vspace*{\\lang_header_adjustment}El combate termina inmediatamente si todas las unidades de un bando son derrotadas.\n" "El bando con unidades supervivientes es el ganador.\n" "En combate contra \\textbf{Unidades Neutrales}, si estás \\pagelink{Timelimit}{fuera de tiempo} o tus Unidades son derrotadas, debes \\textbf{Retirarte}; mueve cualquier Unidad superviviente de vuelta a tu Mazo de Unidades y mueve al Héroe de vuelta al Campo \\textbf{del que partía}.\n" "Retirarse no tiene otras consecuencias negativas.\\par\n" ```

To commit them, please comment "po4a commit" 😎

[qwrtln]

@DarthGandalf What do you think? It should prevent any future abuse.

[DarthGandalf]

I don't have a strong opinion on this.