search

Heegu-sama / Homm3BG

Repository for rewriting the rule book.
81 stars 14 forks source link

Hebrew #599

Closed davidpodless closed 1 week ago

davidpodless commented 1 week ago

Starting to translate the Rules book to Hebrew

qwrtln commented 1 week ago

Please, post pictures of the text that was already translated. Also, please update .github/CODEOWNERS file.

qwrtln commented 1 week ago

Also, please target the PR to the main branch, so that the workflows can trigger, and we can see if the file builds properly.

davidpodless commented 1 week ago

Please, post pictures of the text that was already translated. Also, please update .github/CODEOWNERS file.

image image image

There are still a lot of work TBD here. I also have few challenges I don't really know how to fix (Few graphic issue, and few numbers going RTL instead of LTR, you can see an example for that in the 3rd img)

davidpodless commented 1 week ago

Also, please target the PR to the main branch, so that the workflows can trigger, and we can see if the file builds properly.

Shouldn't I wait for all the translation to be ready first?

qwrtln commented 1 week ago

Also, please target the PR to the main branch, so that the workflows can trigger, and we can see if the file builds properly.

Shouldn't I wait for all the translation to be ready first?

No, we have a different workflow. Our approach is to have one PR per section. I'm encouraging you to do it like that. First PR should be just the setup, title page, and that's it. Every other section should get its own PR.

davidpodless commented 1 week ago

Also, please target the PR to the main branch, so that the workflows can trigger, and we can see if the file builds properly.

Shouldn't I wait for all the translation to be ready first?

No, we have a different workflow. Our approach is to have one PR per section. I'm encouraging you to do it like that. First PR should be just the setup, title page, and that's it. Every other section should get its own PR.

So... should I break this PR to 7 PRs? OK so Let's not waste anymore time on this one :-)

qwrtln commented 1 week ago

So... should I break this PR to 7 PRs? OK so Let's not waste anymore time on this one :-)

Yes, exactly. The first one should be just a scaffold for the translation. Believe me, it will make everyone's life easier. It's better to split the work into bite-size chunks, instead of a huge PR weeks behind the main branch.

DarthGandalf commented 1 week ago

Actually it's "страница", not what you said. And it's supposed to be стр. instead of с.

But that makes text of printable version much longer, and breaks the layout on many pages. With incorrect but short "c." the effect is not as severe