search

Heegu-sama / Homm3BG

Repository for rewriting the rule book.
122 stars 24 forks source link

[HE] setup translation #600

Closed davidpodless closed 3 months ago

davidpodless commented 3 months ago

This is the setup of the Hebrew translation

There are few problems I couldn't solved and if someone has an idea how to fix them - it will be awesome.

  1. it get stuck when running tools/build.sh he here: (./sections/translated/he/title_page.tex) [1<./assets/layout/tausta.png><./asse ts/layout/bottom.png><./assets/layout/cover.jpg><./assets/layout/cover_title.pn g><./assets/layout/cover_subtitle.png>] ! Undefined control sequence. \versionlabel {} \input {.version} l.303 }

?

Enter solved it, but I think it causes some graphical issues in the pdf

image

  1. as you can see in the image, the English part is written backwards. it isn't a big of an issue, since it will be translated to Hebrew. The more problematic part is page numbers like this:

    image

  2. page 9 (and 16, 19 etc.) has green dots with numbers in it. but while the picture stay the same in English and hebrew, the dots moved.

    image

Any idea of how to solve any of the problems would be appreciated.

qwrtln commented 3 months ago

A couple of things:

  1. Please see how version is handled now in main_*.tex files. You're working on an outdated baseline. Fixing it will fix the problem of LaTeX compilation stopping.
  2. I think graphical issues are not related to the issue above. Those images are placed on the page using coordinates. Since the direction of the text is different, coordinates will most likely need to be adjusted.
  3. The dots probably suffer from the same issue. My guess is that you'll have to "mirror" the coordinates vertically. I wouldn't worry about it now, let's fix it once the setup is functional, and it's time to translate the appropriate section.
  4. Please, target the PR to the main branch. We need to make sure all the checks are passing before merging anything. You should work on the main branch, not create a separate branch and merge once all translations are done. The risk of later conflicts is just not worth it.