HeidelTime / heideltime

A multilingual, cross-domain temporal tagger developed at the Database Systems Research Group at Heidelberg University.
GNU General Public License v3.0
342 stars 67 forks source link

Overflow in quarter logic #53

Open kno10 opened 7 years ago

kno10 commented 7 years ago

HI, As I have been refactoring (and simplifying) the disambiguation code, I have found the following problematic strings:

November 2015, 1 quarter later.
January 2015, 1 quarter earlier.

Which will yield 2015-Q5 and 2015-Q0.

The reason is that the quarter logic computes the mod-4 on the delta, not on the resulting value.

In my refactoring branch, I have a bug fix for this.