search

HeidelTime / heideltime

A multilingual, cross-domain temporal tagger developed at the Database Systems Research Group at Heidelberg University.
GNU General Public License v3.0
343 stars 67 forks source link

Update StringUtils.java #79

Open elasticjava opened 5 years ago

elasticjava commented 5 years ago

my first contact with your code - i added the maven dependencies and stumpled into the wrong (your) StringUtils class and ended in an infinite loop. You should point out the very experimental state of your project!

kno10 commented 5 years ago

The function countOccurrences is unused, and probably should just be dropped.

No need to be insulting ("very experimental state"). May I point out that errors occur even in the most mature projects, in particular in unused code. For example, the widely known and respected Stanford CoreNLP package used to have an invalid covariance method (that wouldn't compute covariance). As it was unused, it was removed in 2018: stanfordnlp/CoreNLP/pull/592 I would not call CoreNLP "very experimental" though either... mistakes happen.