Suspicious line in code for Nucleo64, 16x16d - Githubissues

HeimannSensor / Nucleo-64-STM32F446RE-Application-Shield

Sample code for the Nucleo-64 STM32F446RE board and HTPAd Application Shield (written in the Arduino IDE).

1 stars 2 forks source link

Suspicious line in code for Nucleo64, 16x16d #1

Open pwiecz opened 2 years ago

pwiecz commented 2 years ago

In line: https://github.com/HeimannSensor/Nucleo-64-STM32F446RE-Application-Shield/blob/019f7191cadc409206b37c8352c7300ef1f057d8/16x16/htpad16x16_nucleo_serial_06012020/htpad16x16_nucleo_serial_06012020.ino#L891 constant E_THOFFSET is being used for reading pij array. It seems that E_PIJ should be used there.

pwiecz commented 2 years ago

Same issue is in the code for ethernet: https://github.com/HeimannSensor/Nucleo-64-STM32F446RE-Application-Shield/blob/main/16x16/htpad16x16_nucleo_ethernet_06012020/htpad16x16_nucleo_ethernet_06012020.ino and in the code for Arduino DUE: https://github.com/HeimannSensor/Nucleo-64-STM32F446RE-Application-Shield/blob/main/16x16/htpad16x16_nucleo_ethernet_06012020/htpad16x16_nucleo_ethernet_06012020.ino https://github.com/HeimannSensor/Arduino-DUE-Application-Shield/blob/main/16x16/htpad16x16_arduino_serial_06012020/htpad16x16_arduino_serial_06012020.ino Code for ESP32 seems to be "fixed".

HeimannSensor commented 2 years ago

oh, yes. you are absolutly right. I will fix that