search

HeinrichApfelmus / threepenny-gui

GUI framework that uses the web browser as a display.
https://heinrichapfelmus.github.io/threepenny-gui/
Other
437 stars 77 forks source link

Expose the underlying JSObject of an Element. #181

Closed pepeiborra closed 7 years ago

pepeiborra commented 7 years ago

As discussed, this will enable easier management of custom JSObject lifetimes, as illustrated by the new version of ffiExport.

HeinrichApfelmus commented 7 years ago

Hm, it seems to me that ffiExport' is beginning to duplicate the API in Foreign.JavaScript. I think it's better to export the function liftJSWindow right away.

Also, could you put both functions in an extra section "Internals"? This makes it more clear that they are stopgap measures.

pepeiborra commented 7 years ago

Done as requested.

HeinrichApfelmus commented 7 years ago

Looks good now. Thanks!

meteficha commented 6 years ago

It looks like this PR was merged a couple of months before the 0.8.0.1 release, but it was not included there. Was that an oversight?

HeinrichApfelmus commented 6 years ago

Adding new functions would require a 0.8.1.0 release. Our co-maintainer Simon Jakobi made the 0.8.0.1 release (thanks!) mainly to ensure compatibility with GHC 8.2.

meteficha commented 6 years ago

Makes sense!

sjakobi commented 6 years ago

Next time I need to bump a dependency version, I'll look what kind of unreleased changes are lying around. If there are any, I'll ask @HeinrichApfelmus if he'd mind me releasing them too.

HeinrichApfelmus commented 6 years ago

Ok, sounds good, thanks!