Fix refX, refY spelling

HeinrichApfelmus / threepenny-gui

GUI framework that uses the web browser as a display.

https://heinrichapfelmus.github.io/threepenny-gui/

Other

441 stars 77 forks source link

Fix refX, refY spelling #225

Closed ggreif closed 6 years ago

ggreif commented 6 years ago

It appears to be case sensitive in FireFox.

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/refX

To be clarified:

[ ] change spelling of Haskell r/w attribute too? (means version bump)
[x] introduce Haskell aliases refX and refY? (means minor version bump, preferred)
[x] deprecate old Haskell refx and refy bindings?

sjakobi commented 6 years ago

Did you check that the new spelling is compatible with other browsers?

ggreif commented 6 years ago

It is the official spelling. There is no lowercase spelling. Here is the link: https://www.w3.org/TR/SVG11/painting.html#MarkerElementRefXAttribute

I have only found one misspelled version on jsfiddle.net: https://jsfiddle.net/m1erickson/9aCsJ

Using unpatched threepenny-gui here are my observations:

Checked that IE11 (v11.611.16299.0) also does not like lowercase refx and refy. Arrowheads are offset without the patch and correct with the patch.
Same for Firefox v62.0.0.2, however upon reading the above jsfiddle, FF will auto-correct the attribute spellings. You can see the fixed DOM in the inspector.

sjakobi commented 6 years ago

LGTM!

HeinrichApfelmus commented 6 years ago

Nice! Looks just like a simple spelling mistake, indeed.

@sjakobi Feel free to merge this change. I think the deprecation allows a minor version bump, but it might not be accepted to Hackage if I understand correctly. It might require a version bump to ≥ 0.9.0.0 .

sjakobi commented 6 years ago

I think the deprecation allows a minor version bump, but it might not be accepted to Hackage if I understand correctly.

In my understanding, it's packages that use -Werror that are rejected by Hackage. A minor version bump should be fine for this release.