search

HeinrichApfelmus / threepenny-gui

GUI framework that uses the web browser as a display.
https://heinrichapfelmus.github.io/threepenny-gui/
Other
437 stars 77 forks source link

Update Electron #246

Open bradrn opened 3 years ago

bradrn commented 3 years ago

threepenny-gui’s recommended package.json uses Electron version ^1.6.1. By contrast, the Electron quickstart package.json uses Electron version ^10.1.3 — nine major versions later! It looks like threepenny-gui desperately needs to upgrade its Electron version. To do this, the package versions in package.json would need to be upgraded; after that the provided electron.js will probably need to be changed as well, in order to keep it working with the updated package versions.

(This seems like a simple change, and I would submit a PR myself, except that (a) my knowledge of the node.js ecosystem is practically nonexistent, and (b) I cannot build threepenny-gui, and thus am unable to test any changes I may make. If by some miracle I manage to get everything working again, I can certainly try to submit a PR for this, but until then I can’t really do anything with threepenny-gui.)

sjakobi commented 3 years ago

Unfortunately I'm also quite unfamiliar with Electron and the node ecosystem. I'd appreciate a PR!

adi-mohan commented 3 years ago

Hi! May I work on this issue?

adi-mohan commented 3 years ago

Also, you should almost never use electron in dependencies. It should be under devDependencies, reason being electron is not advised to install on production environment. I will initiate PR, whenever you respond to this. @bradrn @HeinrichApfelmus @sjakobi

bradrn commented 3 years ago

I’d be happy for you to work on this issue, although it would be nice to have some comment from @HeinrichApfelmus on whether that’s OK (which I assume it is).

HeinrichApfelmus commented 3 years ago

@adi-mohan Yes, please! I'm not very familiar with the npm ecosystem, so any help is appreciated.

bradrn commented 3 years ago

Update on this issue: I’ve been working recently on a threepenny-gui application in Electron, and I think I’ve managed to get it working with the latest versions of everything. I’d like to do a rewrite of the existing tutorial to get it a bit more up-to-date, but I think I’ll just wait a bit until I’m confident I’ve gotten everything working properly.