search

HeinrichApfelmus / threepenny-gui

GUI framework that uses the web browser as a display.
https://heinrichapfelmus.github.io/threepenny-gui/
Other
439 stars 77 forks source link

text-1.1 and aeson-0.7 support #77

Closed snoyberg closed 10 years ago

snoyberg commented 10 years ago

Currently, text versions 1.0 and 1.1 are excluded by the version bounds. Could you release a new version with a relaxed upper bound on text?

HeinrichApfelmus commented 10 years ago

Sure. I probably won't be able to test it with the new versions, though, as I still have an old Haskell platform. Are there any breaking changes that I should be aware of?

snoyberg commented 10 years ago

I'm not aware of any significant breaking changes.

HeinrichApfelmus commented 10 years ago

I have adjusted the dependency on the text package and released version threepenny-gui-0.4.1.0 on hackage.

snoyberg commented 10 years ago

Thanks!

snoyberg commented 10 years ago

Thanks! I also just noticed the upper bound on aeson, would it be possible to relax that as well?

HeinrichApfelmus commented 10 years ago

I noticed that as well, but there are some compatibility issues with aeson-0.7. Some fixes are already in the development branch, but they are a bit buried and it's easier for me to make it part of the 0.5 release.

peti commented 10 years ago

We have updated the NixOS distribution to aeson 7.x a long time ago, and now we have trouble packaging threepenny-gui because it doesn't support that version. Would it be possible to get an update of the package that add supports for aeson 7.x in the near future? That would make our lives quite a bit easier!

snoyberg commented 10 years ago

@peti I'm using this patch in Stackage:

https://github.com/fpco/stackage/blob/master/patching/patches/threepenny-gui-0.4.1.0.patch

It also adds back support for older versions of bytestring.

peti commented 10 years ago

@snoyberg, very nice, thanks for the pointer!

HeinrichApfelmus commented 10 years ago

Thanks for the patch, @snoyberg ! Will go into upcoming 0.4.1.1 release.

HeinrichApfelmus commented 10 years ago

Note that while the patch

https://github.com/fpco/stackage/blob/master/patching/patches/threepenny-gui-0.4.1.0.patch

makes the code compile, it breaks some functionality. The latest master branch contains the proper fixes.

peti commented 10 years ago

Would it be possible to have the new version available via Hackage?

HeinrichApfelmus commented 10 years ago

Yes. I'm just waiting for confirmation that the examples all work. #82