search

HeinrichApfelmus / threepenny-gui

GUI framework that uses the web browser as a display.
https://heinrichapfelmus.github.io/threepenny-gui/
Other
439 stars 77 forks source link

Fix table reference to SVG elements (for deleting elements) #99

Closed jvdp closed 9 years ago

jvdp commented 9 years ago

It turns out that you couldn't delete SVG elements because the elid was a bit mangled (see patch.) Removing this mangling seemed to be the simplest way to fix it.

HeinrichApfelmus commented 9 years ago

Just a preview: I'm currently redesigning the JavaScript FFI, which will likely make this issue obsolete. I'll write a comment when this is the case.

HeinrichApfelmus commented 9 years ago

This should be fixed since commit 36e9afa74aa4dd996e86ae5497e103b7af8975ec . Could you check that this is indeed the case?

jvdp commented 9 years ago

Yep, seems to work well! :+1:

Just a heads up: I see that you changed Config fields' prefix from tp to js and the Game and VideoAnnotate examples are not updated yet (though they seem to be excluded from the cabal file as well.)

HeinrichApfelmus commented 9 years ago

Yup, I've designated Game and VideoAnnotate for bitrotting. :recycle: