search

Heisenbergjs / heisenberg

A project base for building modern JavaScript applications
http://heisenbergjs.github.com/heisenberg/
156 stars 12 forks source link

Pulldown as devDependency #30

Closed OliverJAsh closed 11 years ago

OliverJAsh commented 11 years ago

It's unlikely the user will have it installed globally. Am I good to add it?

jackfranklin commented 11 years ago

If you can find a way to specify a global dependency, sure. I'm not sure it's doable.

FWIW, the Heisenberg npm module does check pulldown is installed (and installs it if it's not) for the user.

OliverJAsh commented 11 years ago

I was just thinking of adding it as a local dependency. Didn't realise the npm module did that for you, but I don't see why it shouldn't also be inside package.json? Then the npm module can just run npm install.

jackfranklin commented 11 years ago

pulldown is a module that's intended to be installed globally, so the pulldown executable is available on your system. Installing it locally would lead to the user having to do:

./node_modules/pulldown/bin/pulldown instead of just pulldown.

OliverJAsh commented 11 years ago

You're right!