search

Heisenbergjs / heisenberg

A project base for building modern JavaScript applications
http://heisenbergjs.github.com/heisenberg/
156 stars 12 forks source link

Minor improvement in main.js #33

Closed boye closed 11 years ago

boye commented 11 years ago

Passed app.init directly as argument of the .ready method, instead of the anonymous function. As stated in this comment

jackfranklin commented 11 years ago

@boye thanks for this! Please feel free to make a new Pull Req adding yourself to the contributors list in the README :+1:

boye commented 11 years ago

Just to be sure; editing the README should be done via git flow as well right?

jackfranklin commented 11 years ago

@boye no, for the README I don't think it's worth it. Any code changes should go through Git Flow, keep them in feature branches, merge them into your develop branch then Pull Req on that.

Small README changes should just be done on master - keep it simple.