search

Hekili / hekili

Hekili Priority Helper for DPS and Tanks (WoW Retail)
298 stars 162 forks source link

Updated Glyphs, Talents and Abilities + added missing commas #3267

Closed frissle closed 1 month ago

frissle commented 1 month ago

Talents Updated for Cataclysm Classic

Updated Glyph List: The glyph list has been updated from the Wrath of the Lich King version to the Cataclysm Classic version.

Alphabetical Sorting: The new glyph list is now sorted alphabetically for better readability and maintenance.

Removed Glyphs: curse_of_agony curse_of_exhausion quick_decay searing_pain siphon_life souls succubus

Added Glyphs: lash_of_pain

Changes: chaos_bolt ID changed from [63304] to [45781]. conflagrate ID changed from [56235] to [42454]. corruption ID changed from [56218] to [42455]. death_coil ID changed from [56232] to [42457]. demonic_circle ID changed from [63309] to [45782]

Updated Abilities: The following abilities were updated with new information from data.lua: Updated properties: banish challenging_howl chaos_bolt conflagrate corruption

New Abilities: The following abilities were added to Warlock.LUA.

bane_of_doom curse_of_the_elements bane_of_agony seed_of_corruption dark_intent

Added missing commas after each ability definition block from lines 761 to 2650 to prevent potential syntax errors.

Hekili commented 1 month ago

What's the reasoning for deleting/overwriting most of the ability handlers with stubs?

Supernuss commented 1 month ago

looks like he used my webscraper and pasted the results in directly without fixing them first (--fix:)

Supernuss commented 1 month ago

Im implementing the abilities locally now and will create a new PR when I'm done (probably tomorrow or something)

Supernuss commented 1 month ago

@Hekili I created https://github.com/Hekili/hekili/pull/3274 instead, applying the relevant functions and including old and new handlers.

Should contain everything that is in here as well, so you could close this one :)