[REC] The bug with cooldown(offset) for primary priority

savelichev commented 2 months ago

Before You Begin

[X] I confirm that I have downloaded the latest version of the addon.
[X] I am not playing on a private server.
[X] I checked for an existing, open ticket for this issue and was not able to find one.
[X] I edited the title of this issue (above) so that it describes the issue I am reporting.
[X] I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Describe the Issue

Cata Classic. Warlock. Demon. In general addon works nice. But when i cast "Ritual of Souls" it provides 1 min cooldown(offset) for all priorities, like addon is paused. This offset value is a chanelling time of the e.g. "Ritual of Souls" spell. Even when i apply dots it shows them in prio list. So addon does not work until this cooldown passed When i cast "Ritual of summoning" it provides 2min cooldown

How to Reproduce

Enter the game as Warlock
Go to the training dummy
Enable addon
Before the battle click on the "Ritual of Souls" or "Ritual of Summoning"

Snapshot (Link)

https://pastebin.com/9XTZTwz1

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

georgedeam commented 2 months ago

it will also do this for summoning, i fixed this in the meantime by commenting out the two ritual spells in warlock.lua

Hekili commented 2 months ago

It should do this while you're casting/channeling (even with the hidden cast bar), as long as it stops when you complete or interrupt your ritual. Are you saying that it stays like that afterward?

georgedeam commented 2 months ago

yes it stays the entire 2 minutes of the summon cooldown

savelichev commented 1 month ago

yes, it take like the channel time for cast 1min for ritual of souls and 2min for ritual for summoning, and apply this time as an offset for rotation even if you stop channeling. So if start cast right before the battle, rotation will be like on pause until this offset passed. The tip from @georgedeam, to comment both spells in the warlock sources helped.

georgedeam commented 1 month ago

It appears that it is commented out on the retail version, maybe an oversight for cata?

--[[ Begins a ritual that sacrifices a random participant to summon a doomguard. Requires the caster and 4 additional party members to complete the ritual.
    ritual_of_doom = {
        id = 342601,
        cast = 0,
        cooldown = 3600,
        gcd = "spell",
        school = "shadow",

        spend = 1,
        spendType = "soul_shards",

        startsCombat = false,

        toggle = "cooldowns",

        handler = function ()
        end,
    },

    -- Begins a ritual to create a summoning portal, requiring the caster and 2 allies to complete. This portal can be used to summon party and raid members.
    ritual_of_summoning = {
        id = 698,
        cast = 0,
        cooldown = 120,
        gcd = "spell",
        school = "shadow",

        spend = 0.05,
        spendType = "mana",

        startsCombat = false,

        toggle = "cooldowns",

        handler = function ()
        end,
    }, ]]

Hekili / hekili