Assasination doesn't recommend Crimson Tempest

sixsi commented 3 weeks ago

Before You Begin

[X] I confirm that I have downloaded the latest version of the addon.
[X] I am not playing on a private server.
[X] I checked for an existing, open ticket for this issue and was not able to find one.
[X] I edited the title of this issue (above) so that it describes the issue I am reporting.
[X] I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Describe the Issue

Addon doesn't recommend Crimson Tempest at all.

How to Reproduce

Enter the game as Assasination Rogue.
Start your rotation on AoE dummies or in any combat with 3+ targets
See the addon doesn't recommend Crimson Tempest at any point of the rotation

Snapshot (Link)

https://pastebin.com/A9Q5yqGf

Raidbots Sim Report (Link)

No response

Additional Information

Assasination priority looks not optimal in general. E.g. right now it recommends to use Kingsbane and then to apply Slice and Dice which is not optimal for the burst window (should apply bleeds and Slice and Dice BEFORE using Kingsbane). Updates would be appreciated :)

Contact Information

No response

OppYchan commented 3 weeks ago

Having the same issue on this one

Hekili commented 3 weeks ago

Looks like the energy_regen_combined requirement is too aggressive (again). I'll low this threshold and/or make it a setting to configure.

sixsi commented 3 weeks ago

this was a mop remix issue i guess. just got my char on retail and addon recommends crimson tempest :)

Fusroedah commented 3 weeks ago

There's some scenarios where it does recommend CT, it's extremely rare and it usually recommends Envenom over it, however it can potentially appear. Sounds like Hekili has figured out the issue above

bobbytwotime commented 3 weeks ago

I'm here to chime in the same report. CT is extremely rare not sure if its a energy thing when envenom or ct is max energy is always envenom.

cutterbup commented 2 weeks ago

seems like it still doesnt work. anyone still has the same problem?

w1tch666 commented 2 weeks ago

Crimson Tempest is never being recommended neither on 5 target dummies or any packsize in a dungeon.

edit: for now you can go to Priorities->Assassination->Action List->aoe_dot->Entry 1.Crimson Tempest

and modify the conditions at the bottom "energy.regen_combined > 25" to a lower number like 5

cutterbup commented 2 weeks ago

Crimson Tempest is never being recommended neither on 5 target dummies or any packsize in a dungeon.

edit: for now you can go to Priorities->Assassination->Action List->aoe_dot->Entry 1.Crimson Tempest

and modify the conditions at the bottom "energy.regen_combined > 25" to a lower number like 5

thank you!

zzhao223 commented 2 weeks ago

Assasination doesn't recommend garrote/ rupture when switch targets， anyone else？

Fusroedah commented 2 weeks ago

Zzhao that sounds like a separate issue, please open a separate ticket

Thanks,

Jake

On Sat, Aug 24, 2024 at 3:36 AM zzhao223 @.***> wrote:

Assasination doesn't recommend garrote/ rupture when switch targets， anyone else？

— Reply to this email directly, view it on GitHub https://github.com/Hekili/hekili/issues/3495#issuecomment-2308170940, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5VFZRAFOZG3CHANKOQ4NALZTAZY5AVCNFSM6AAAAABMVN6JWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGE3TAOJUGA . You are receiving this because you commented.Message ID: @.***>

Richard-Holness commented 2 weeks ago

Crimson Tempest is never being recommended neither on 5 target dummies or any packsize in a dungeon.

edit: for now you can go to Priorities->Assassination->Action List->aoe_dot->Entry 1.Crimson Tempest

and modify the conditions at the bottom "energy.regen_combined > 25" to a lower number like 5

I can't seem to find this line anywhere in that section of the add-on. my condition text read "spell_targets >= 3 & variable.dot_finisher_condition & refreshable & ! cooldown.deathmark.ready & target.time_to_die - remains > 6"

Hekili commented 2 weeks ago

I already removed the energy requirement from the 11.0.2-1.0.4 release. If this is still occurring, a snapshot with the latest version of the addon (at full combo points, in a multi-target scenario) is needed.

Fusroedah commented 2 weeks ago

Fixed!

On Mon, Aug 26, 2024 at 3:40 PM Hekili @.***> wrote:

I already removed the energy requirement from the 11.0.2-1.0.4 release. If this is still occurring, a snapshot with the latest version of the addon (at full combo points, in a multi-target scenario) is needed.

— Reply to this email directly, view it on GitHub https://github.com/Hekili/hekili/issues/3495#issuecomment-2310944022, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5VFZRASMIERF44K4EAKQO3ZTOACTAVCNFSM6AAAAABMVN6JWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQHE2DIMBSGI . You are receiving this because you commented.Message ID: @.***>

zzhao223 commented 2 weeks ago

Hi Fusro，

i Checked the new release but no assisn rouge update

Fusroedah @.***>于2024年8月26日周一15:50写道：

Fixed!

On Mon, Aug 26, 2024 at 3:40 PM Hekili @.***> wrote:

I already removed the energy requirement from the 11.0.2-1.0.4 release. If this is still occurring, a snapshot with the latest version of the addon (at full combo points, in a multi-target scenario) is needed.

— Reply to this email directly, view it on GitHub https://github.com/Hekili/hekili/issues/3495#issuecomment-2310944022, or unsubscribe < https://github.com/notifications/unsubscribe-auth/A5VFZRASMIERF44K4EAKQO3ZTOACTAVCNFSM6AAAAABMVN6JWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQHE2DIMBSGI>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Hekili/hekili/issues/3495#issuecomment-2310961044, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKX5BZXIZUXKZQTK76H57TTZTOBJPAVCNFSM6AAAAABMVN6JWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQHE3DCMBUGQ . You are receiving this because you commented.Message ID: @.***>

Hekili / hekili