Hekili / hekili

Hekili Priority Helper for DPS and Tanks (WoW Retail)
420 stars 221 forks source link

[REC] Augmentation Empowered Spells, CDs #3797

Closed tpfleck closed 1 month ago

tpfleck commented 2 months ago

Before You Begin

Spec

Evoker - Augmentation

Describe the Issue

While in combat during M0 w/ adds (non-boss), it doesn't recommend my empowerment spells, tip the scales, or breath of eons. The second I start fighting a boss, it recommends everything properly. When I fighting non-boss dummies, it recommends the appropriate rotation.

My group is done with M0s until starting M+ tomorrow, so I'm not able to upgrade a Snapshot of it actively happening at the moment. Will paste once I run into the issue again.

How to Reproduce

  1. Enter game as Aug
  2. Enter a M0 and start fighting some non-boss mobs
  3. Witness it doesn't recommend tip the scales, empowerments, or breath.

Snapshot (Link)

pastebin

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/5Rkt5ma9JJccdSmPGLGHmJ

Additional Information

No response

Contact Information

No response

Levion0810 commented 2 months ago

Unfortunately, it still doesn't work for me too :(

GitBearded commented 2 months ago

Unfortunately, it still doesn't work for me too :(

Did you by chance have “boss encounters only” checked in your settings?

Hekili commented 2 months ago

Need to take a snapshot when your CDs/rotation is not working in M+.

A snapshot is required to diagnose this issue.

Snapshot

Please supply a Snapshot of the addon's decision-making when you are seeing this issue in-game. This is not a screenshot. To generate a Snapshot, please complete the following steps.

This step is essential, as most issues are related to specific classes, specializations, gear, talent choices, or other game systems. If you do not provide this information, I cannot triage your problem.

tpfleck commented 2 months ago

Updated - https://pastebin.com/QngRZSYg

Levion0810 commented 2 months ago

Unfortunately, it still doesn't work for me too :(

Did you by chance have “boss encounters only” checked in your settings?

No :(

tpfleck commented 2 months ago

Unfortunately, it still doesn't work for me too :(

Did you by chance have “boss encounters only” checked in your settings?

Also no

Levion0810 commented 1 month ago

May this helps, Version Hekili-v11.0.2-1.0.10b works @ trash mobs

tpfleck commented 1 month ago

Thanks Levion, I'll look at that until this gets updated.

syrifgit commented 1 month ago

toggles: cooldowns = false

Your cooldowns are disabled which almost certainly includes atleast some of those abilities.

Your snapshot also doesn't really help because it only shows 1 icon, so we cannot see any logic past the point where it chose to cast prescience, and the abilities you are concerned about are after prescience in the list. Get a snapshot showing 3+ icons.

Irenside commented 1 month ago

It happened multiple times on this run. Not sure how snapshots work so got three. v11.0.2-1.0.10b is the only version that works correctly:

https://pastebin.com/AMyS2JfZ https://pastebin.com/9z4GA5hk https://pastebin.com/aaPsiiEd

Thanks!

syrifgit commented 1 month ago

Looks like there are already multiple changes/fixes in place for the next addon update, hold off until then.

syrifgit commented 1 month ago

Next version has been released and should be on places like Curseforge soon. Please test once you can update to the newest version.

https://github.com/Hekili/hekili/releases/tag/v11.0.2-1.0.15a

Hekili commented 1 month ago

(1.0.15a)

Levion0810 commented 1 month ago

I think i have found the problem, when I use the buff Sense Power, then Breath of Eons, Upheavel and Fire Breath are no longer displayed... with the buff switched off everything works as it should.

Thanks for ur Time, PS i use the newest Version v11.0.2-1.0.16

Irenside commented 1 month ago

016 is still not recommending the empowered spells right after ebon might. If I press an empowered spell when it doesn't tell me to but it's the right time, the display will switch to showing it immediately. Also, fire breath is always being recommended at level 3, it was suggesting level 1 previously to take advantage of molten embers. One trash and one boss snapshot below.

https://pastebin.com/nsDhSw7S https://pastebin.com/1UYFbMCM

It worked correctly 90% of the dungeon and my dps was much better. Thanks again.

saltmastergeneral commented 1 month ago

016a also does not seem to be reccing yet I assume he was fixing the lua stuff but I am on dummy ST not getting recced Tip or any empowered spells when breath of eons is off of CD

notoriousmonster commented 1 month ago

Experiencing issues after updating, empowered spells not being recommended on Ulgarax at the moment, no breath of eons, etc to keep Ebon Might up

Irenside commented 1 month ago

016a was hitching also, but when I disabled Sense Power, it "seemed" to work better (if that's a thing).

Sorry, snapshot's:

  1. Sense Power On: https://pastebin.com/6V20KZAZ
  2. Sense Power Off: https://pastebin.com/9b7ax0F1
  3. Sense Power Off (Boss): https://pastebin.com/CRr6MfQu
saltmastergeneral commented 1 month ago

agree turning off Sense Power seems to improve it

Hekili commented 1 month ago

Please don't add to the thread without including your own snapshot. I can't even be certain of what addon version you're on if you don't snapshots.

Levion0810 commented 1 month ago

https://pastebin.com/BEKD3qaf

Sometimes it works, sometimes it doesn't like in this snapshot.

Irenside commented 1 month ago

16b: Tested in follower dungeon, after using Ebon Might, neither empowered spells were suggested. Went back to 10b and tried the same dungeon with no issues.

16b: https://pastebin.com/yVtJebNr 10b: https://pastebin.com/NNhK0JMA

Hekili commented 1 month ago

Thanks for the snapshots. I have made adjustments; I am not sure I like the Breath of Eons timing but I'm seeing Fire Breath and Upheaval more. Please try v1.0.16c.

Irenside commented 1 month ago

Edited - See below

Irenside commented 1 month ago

It was fine for the first dungeon, the 2nd one I did it went back to the old behavior.

https://pastebin.com/rF2GNCGR https://pastebin.com/1J9htBKY (No empowered spells for length of EM)

Hekili commented 1 month ago

With Sense Power active, the addon waits to see allied CDs pop before FB / BoE / Upheaval, but I'll relax those requirements.