[REC] Prot Warrior is not recommending Last Stand or Shield Wall.

winnerwinnington commented 1 week ago

Before You Begin

[X] I confirm that I have downloaded the latest version of the addon.
[X] I am not playing on a private server.
[X] I checked for an existing, open ticket for this issue and was not able to find one.
[X] I edited the title of this issue (above) so that it describes the issue I am reporting.
[X] I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Warrior - Protection

Describe the Issue

Last stand conditions from the addon: ( target.health.pct >= 90 & talent.unnerving_focus.enabled | target.health.pct <= 20 & talent.unnerving_focus.enabled ) | talent.bolster.enabled | set_bonus.tier30_2pc | set_bonus.tier30_4pc

I have neither talent, and I think Tier 30 is two sets ago? TWW Season 1 is Tier 32 - right?

This problem extends to Shield Wall which appears to only require the talent immovable object. talent.immovable_object.enabled & buff.avatar.down

Are either these connected to their sliders for health % and incoming damage?

How to Reproduce

Enter the game as a Prot Warrior
Don't take unnerving focus, or bolstering
Equip any non-tier 30 gear
lose nearly all your health

Snapshot (Link)

https://pastebin.com/JTFXe5y6

Raidbots Sim Report (Link)

N/A

Additional Information

None.

Contact Information

Staypuft#8032

Hekili commented 1 week ago

( target.health.pct[97.86] >= 90 & talent.unnerving_focus.enabled[false] | target.health.pct[97.86] <= 20 & talent.unnerving_focus.enabled[false] ) | talent.bolster.enabled[false] | set_bonus.tier30_2pc[0.00] | set_bonus.tier30_4pc[0.00]

Probably needs criteria updates, but currently requires Unnerving Focus, Bolster, or tier 30.

Spike2D commented 6 days ago

tanking & incoming_damage_5s > last_stand_damage_taken & health.pct <= last_stand_health_pct & ! ( buff.shield_wall.up | buff.last_stand.up | buff.rallying_cry.up | buff.potion.up )

Would this be correct @Hekili ?

Spike2D commented 5 days ago

Added Mitigations correctly to both SimC and tied them to the settings.
Added Victory Rush/Impending Victory setting as well as added them to SimC.
Removed Last Stand used Offensively option, not relevant anymore.

Pull request: #3846

SerhatSoruklu commented 5 days ago

Hello im also a prot warrior its not recommending last stand, shield wall, rallying cry, slam, impending victory and many others...

Hekili commented 5 days ago

PR merged for next release.

Hekili / hekili