Hekili / hekili

Hekili Priority Helper for DPS and Tanks (WoW Retail)
393 stars 206 forks source link

[REC] Hekili Not Recommending Key Abilities for Warrior Protection #3850

Open SerhatSoruklu opened 2 hours ago

SerhatSoruklu commented 2 hours ago

Before You Begin

Spec

Warrior - Protection

Describe the Issue

For my Warrior Protection spec, the Hekili addon is not recommending several key abilities during combat. It only seems to focus on Ignore Pain, Shield Block, Revenge, and a few others, but it is consistently neglecting important abilities such as:

Rallying Cry Shield Wall Whirlwind Action Button Rend Slam Impending Victory (even when my health is low) This is affecting my ability to execute a proper rotation, as it does not guide me to use the full range of my toolkit. Additionally, it is not recommending my DPS trinket at all.

I would like to know how I can adjust the settings so that it incorporates these abilities and the use of my DPS trinket into the rotation recommendations.

How to Reproduce

How to Reproduce: Play as a Protection Warrior. Set up the Hekili addon with default settings. Enter combat and observe that abilities like Rallying Cry, Shield Wall, Whirlwind, Rend, Slam, and Impending Victory are not being recommended. Try to use the DPS trinket, but notice it is not being suggested by the addon.

Snapshot (Link)

https://pastebin.com/Uy8CvAG0

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/ghRwkwavUSH2TvhbWSWaKL

Additional Information

As you can see from the snap shot its only recommending thunder, ignore pain, shield block and a couple others

Contact Information

Discord: Coupyn

Spike2D commented 2 hours ago

Duplicate of #3830 Pull fix already submitted. Rend, Slam and Whirlwind are not recommended on purpose, we don't and shouldn't actively use those skills for our rotation.

What DPS trinket you're using?

SerhatSoruklu commented 2 hours ago

Ahh right I see. Pull fix already submitted when will the addon update for these fixes cause I updated just now and restarted wow, still nothing.

Also Im using this trinket: https://www.wowhead.com/item=219915/foul-behemoths-chelicera

Spike2D commented 2 hours ago

@Hekili will need to review and merge it, so it's not live yet.

The pull also fixes Foul Behemoths trinket mismatched ID.