[REC] VDH Reset Fel Dev cooldown is not properly calculated

dubudevs commented 1 month ago

Before You Begin

[X] I confirm that I have downloaded the latest version of the addon.
[X] I am not playing on a private server.
[X] I checked for an existing, open ticket for this issue and was not able to find one.
[X] I edited the title of this issue (above) so that it describes the issue I am reporting.
[X] I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

DH - Vengeance

Describe the Issue

Fel Devestation and Fel Desolation have separate cooldowns, and using meta (the button) both resets the fel dev cd and also grants fel desolation. So you can Fel Dev>Meta>Fel Deso for 25 seconds of meta and then Fel Dev will be ready again after it falls off, despite Fel Deso having a ~20 second cooldown when meta falls off. As soon as meta falls off Fel Dev will be usable again.

This itself might seem redundant because Fel Dev cooldown is only 25 seconds if you fully channel it. That aside, it will make prediction better to know that fel dev will always be usable immediately after meta meta falls off even though fel deso still has cooldown. This relies on the fix from https://github.com/Hekili/hekili/issues/3940 which will differentiate meta procced from fel dev/last resort and meta from pressing Metamorphosis

How to Reproduce

Play VDH Press Fel Dev (observe Fel Dev cd) Press Meta Press Fel Desolation (observe Fel Deso cd, ~38s) Cancel Meta (right click buff) Fel Dev is castable

Snapshot (Link)

-

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

taherbert commented 1 month ago

Few notes on this one:

This behavior is a bug that we've reported to Blizzard and they've acknowledged is a bug, but no ETA on when the behavior will be fixed. The "design intent" is that they share a cooldown in the same way that Sigil of Flame and Sigil of Doom do.
Until the above happens, APL is set up currently such that your last few actions during meta are to prepare to enter fel dev immediately after meta ends (ideally, the very first post-meta button press).
Cancelling meta manually was at one point a DPS gain, but that is no longer the case.

dubudevs commented 1 month ago

3. Cancelling meta manually was at one point a DPS gain, but that is no longer the case.

The purpose of the cancel on the "how to reproduce" was just to see that even after 2-3 globals fel dev is available, since if you let meta expire then it would be back anyway with a full channel, if you play the cdr talent.

Hekili / hekili