Hekili / hekili

Hekili Priority Helper for DPS and Tanks (WoW Retail)
426 stars 220 forks source link

[REC] Blood rotation should consume Reaper of Souls procs (Deathbringer) #4103

Closed trbaxter closed 1 month ago

trbaxter commented 1 month ago

Before You Begin

Spec

DK - Blood

Describe the Issue

When using the default profile for Blood, it does not appear that Soul Reaper is recommended in the rotation after Reaper's Mark is applied to a target.


Here are the details of the hero talent:

image


Here's a screenshot of the recommended rotation before Reaper's Mark is used:

image


Notice that after Reaper's Mark is applied to the enemy, Soul Reaper is not recommended at all in the rotation:

image


I have verified that this is not user error by identifying the buff on my character after Reaper's Mark is applied to an enemy:

image


I've also verified that following the recommended BDK rotation results in a DPS loss without this, as one would expect.

Following the rotation resulted in 489,871.0 DPS on a raid target dummy.

Applying Soul Reaper in the rotation per this recommendation resulted in 529,580.1 DPS on the same dummy.

Therefore, I am recommending that the Deathbringer rotation for blood death knights follow this type of pattern if possible:

flowchart TD
    A[Reaper's Mark cast]
    B[Use Soul Reaper]
    C[Continue with rotation]

    A --> B --> C

There may need to be a change added when Exterminate procs are used as well, as Reaper's Mark has a chance to be applied to the target whenever Exterminate is cast. In that case, we would expect the following:

flowchart TD
    A[Cast Exterminate]
    B{Reaper's Mark applied?}
    C((Yes))
    D((No))
    E[Cast Soul Reaper]
    F[Continue rotation]

    A --> B --> C --> E --> F
              B --> D --> F

How to Reproduce

1.) Log into the game as a level 80 blood death knight. 2.) Choose the Deathbringer hero talent tree. 3.) Choose the Reaper of Souls hero talent. 4.) Find any target. 5.) Cast Reaper's Mark on it. 6.) You will see Soul Reaper is not properly displayed in the rotation recogizing the hero talent's effect.

Snapshot (Link)

https://pastebin.com/chBqLiU9

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/qdLkJr7DHRiRmf7jhScg3J

Additional Information

Looking through the sample ability log, it looks like Raidbots is not properly taking advantage of this talent either in the sims, leading an underestimate in potential player output.

(501,835 DPS vs 529.580.1 DPS over the same approximate 3 minute interval)

Contact Information

No response

Hekili commented 1 month ago

The addon will be updated for this tomorrow.