[REC] Stacks of Juggernaut

Juchello40k commented 2 weeks ago

Before You Begin

[X] I confirm that I have downloaded the latest version of the addon.
[X] I am not playing on a private server.
[X] I checked for an existing, open ticket for this issue and was not able to find one.
[X] I edited the title of this issue (above) so that it describes the issue I am reporting.
[X] I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Warrior - Arms

Describe the Issue

In ST build of arms with Juggernaut talent hekili recommend execution every time when proc sudden death. But it must be on 3 stacks of marked of execution or at 2-3 sec of juggernaut talent

How to Reproduce

Enter game at ARMS Warrior, take slayer heroic talents with sudden death and juggernaut talents. See that hekili recommend execution every time when proc sudden death

Snapshot (Link)

https://pastebin.com/ai99eRmD

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

syrifgit commented 2 weeks ago

Provide a sim link please

Mosborne90 commented 2 weeks ago

Below is a snapshot and Sim for Fury impacted by this issue.

Snapshot (Link) https://pastebin.com/dvQRMmya

Raidbots Sim Report (Link) https://www.raidbots.com/simbot/report/3Tte9NSk8XF9ESa6K2c9Hs/simc

syrifgit commented 2 weeks ago

Does this only happen on dummies or any enemy? @Mosborne90 @Juchello40k

I can't tell from the snapshot because 1 is in cryllic and the other doesn't show any enemy names

Hekili commented 2 weeks ago

I've updated the Arms/Fury models to get Marked for Execution stacks from the default API (it is visible). The manual detection was not resetting on using Execute because Execute's damage could have a different spellID than expected.

Mosborne90 commented 2 weeks ago

I've updated the Arms/Fury models to get Marked for Execution stacks from the default API (it is visible). The manual detection was not resetting on using Execute because Execute's damage could have a different spellID than expected.

Tested the issue after the latest update. It appears to be working properly now.

Expected damage distribution:

Hekili rotation damage distribution on live:

Hekili / hekili