[REC] Inconsistent Spellflash for spells that change on procs, such as Tempest, Ice Fury

syrifgit commented 2 weeks ago

Before You Begin

[X] I confirm that I have downloaded the latest version of the addon.
[X] I am not playing on a private server.
[X] I checked for an existing, open ticket for this issue and was not able to find one.
[X] I edited the title of this issue (above) so that it describes the issue I am reporting.
[X] I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Shaman - Elemental

Describe the Issue

Spellflash doesn't always work, even with manually coded keybind. As far as I can tell, it seems to be when the spell proc happens while the spell is already recommended? Someone reported it in Discord and I was able to reproduce.

Screenshot of an instance where it worked

WoWScrnShot_110924_221602

Screenshot where it didn't work

WoWScrnShot_110924_222013

How to Reproduce

Just play any shaman build that uses tempest or Ice Fury, with Spellflash on.

Snapshot (Link)

https://pastebin.com/q5S6HUM2

Raidbots Sim Report (Link)

No response

Additional Information

No response

Contact Information

No response

Hekili commented 2 weeks ago

Ok, your turn to drag SpellFlash's rotting corpse forward into TWW. :)

PopsGG commented 1 week ago

Similar issue with spells changing on proc for blood DKs. I would love a fix if possible. Is SpellFlash abandoned?

syrifgit commented 1 week ago

Spellflash is an addon developed by someone else that is included with Hekili. See FAQ for more info on Spellflash.

PopsGG commented 1 week ago

I know its a 3rd party library/addon, but its functionality works great with Hekili's core use case. I feel it is worth assisting with the fix or building the functionality directly into Hekili itself. If I knew how to code I would try to fix it myself. I ask humbly :)

Hekili / hekili