[REC] Assa Rogue m+ 1 shiv kingsbane issue

yokaii4 commented 3 hours ago

Before You Begin

[X] I confirm that I have downloaded the latest version of the addon.
[X] I am not playing on a private server.
[X] I checked for an existing, open ticket for this issue and was not able to find one.
[X] I edited the title of this issue (above) so that it describes the issue I am reporting.
[X] I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Spec

Rogue - Assassination

Describe the Issue

After the newest update, while playing m+ build with assa rogue (1 shiv charge) the addon suggest to use shiv and thistle tea before sending kingsbane, while it should be used during the last 7-8s while playing with 1 charge. I have also noticed that Skardyn's grace is recommended way before deathmark so we risk losing its buff while in deathmark kingsbane CDs

The snapshots provided should be able to highlight both the shiv and trinket issue

NOTE: I'm aware that the APL suggests from some reason that shiv should be casted before kingsbane, however you can check all the guides that contradicts this + kingsbane does more DPS in its latter half so it is a DPS loss. I guess that the APL just take the ST rotation and misplace the only shiv you have because it considers it 1/2 charges

How to Reproduce

enter game as assa rogue
practice with dummies using the m+ build (1 shiv charge)
execute the rotation

Snapshot (Link)

https://pastebin.com/tq5vj3Mr https://pastebin.com/C2FKaLHX

Raidbots Sim Report (Link)

https://www.raidbots.com/simbot/report/cfheoa2QDDiPV7Np5SUnVn

Additional Information

No response

Contact Information

yokaii__

syrifgit commented 3 hours ago

Sounds like this is worth bringing up to the Rogue APL writers in the Rogue discord. I will take a look eventually, but you should ask them about it too.

yokaii4 commented 3 hours ago

I will, in addition, you could check the correct kingsbane timings thanks to this WA: https://wago.io/OtohaQlq-

Also skardyn's Grace should be used with Deathmark too. Is this hekili's issue or is this something we should bring to the APL writers too?

NOTE: the WA sent tracks only during kingsbane so in case of ST build it can't track the first shiv we send

fzarr commented 2 hours ago

For skardyn's I just remove it from the addon's ability list and macro it into deathmark.

I already researched the shiv thing and the APL is a dps loss but not as much as it sounds like it would be, something like 0.3-0.5% dps. This was already raised in the discord but it doesnt look like its something they care to address.

I manually alter the addon priority list by adding a condition to the shiv fallback line to only work if you have lightweight shiv talented:

actions.stealthed+=/shiv,if=talent.kingsbane&(dot.kingsbane.ticking|cooldown.kingsbane.up)&(!debuff.shiv.up&debuff.shiv.remains<1)&buff.envenom.up

to

actions.stealthed+=/shiv,if=talent.kingsbane&(dot.kingsbane.ticking|cooldown.kingsbane.up)&(!debuff.shiv.up&debuff.shiv.remains<1)&buff.envenom.up&talent.lightweight_shiv.enabled

yokaii4 commented 2 hours ago

Hey @syrifgit apparently it is an unfixed issue but as fzarr said maybe they do not care to fix it since the dps loss is marginal (but still it's more dps for free so why not) about Skardyn, I would just sync it with deathmark or follow what fzarr said above

yokaii4 commented 2 hours ago

@fzarr where do you change the lightweight shiv line specifically?

fzarr commented 2 hours ago

I don't have access to the game atm but its under one of the 'assassination' sections in the left panel, there should be a tab that says priority or action list or something and it has the simcraft APL in a text editor pane. You can modify the line within that APL (might be easier to copy it into a text editor and paste it back into) then you click accept, and then import. You may need a reload too. You can revert any manual changes made to the apl by clicking a circular undo arrow in one of the tabs somewhere.

yokaii4 commented 2 hours ago

I don't have access to the game atm but its under one of the 'assassination' sections in the left panel, there should be a tab that says priority or action list or something and it has the simcraft APL in a text editor pane. You can modify the line within that APL (might be easier to copy it into a text editor and paste it back into) then you click accept, and then import. You may need a reload too. You can revert any manual changes made to the apl by clicking a circular undo arrow in one of the tabs somewhere.

found it thank you! Although for better accessibility for everyone this is something that could be officially done, what do you think? @syrifgit

Hekili / hekili