Closed hoaraucg closed 3 years ago
Your snapshot does not show Starfall currently applied. Was this taken at a time when Starfall was active?
Yeah, If you look at the screenshot, you can see Starfall applied both on the weakaura as well as the buffs in the top right.
Also noticed this. It is suggesting Starfall when there is plenty of duration left on the current Starfall in both AOE and single target situations. Worth mentioning that in a sample simc APL sequence output this behavior is not seen.
NOTE: Suggesting Starfall in a single target situation is not a bug but intended if Star Drift talent is taken.
@hoaraucg I always have to verify that they're actually from the same moment. People make mistakes.
I have a test fix going in a beta build in a few minutes. When 1.0.35-beta2 is available, please confirm whether you still have the issue. Thanks!
I'll gladly check it out tonight. It's very easily reproduceable as long as Convoke procs Starfall, I'll get some info back to you as soon as I see the build release.
It should be up now on GitHub (see Releases tab). Other sites will take longer to approve.
I've tried to do everything I could to break it, and just did 20 minutes straight on a dummy. Not a single Starfall when I wouldn't expect one, seems absolutely perfect now!
Same, looks fixed to me in both ST and AOE! Thanks for fast turnaround!
Thanks for confirming!
Describe the Bug/Issue I've noticed quite often the addon will suggest Starfall, even on single target, when Starfall is still falling and has high duration. It is most often noticed during CA/Convoke, but also occurs randomly during normal rotation when a Starsurge would be the better choice.
To Reproduce Open with 2x Wrath, Moonfire, Sunfire, 2x Starsurge, Celestial Alignment, Convoke. At this point you can gain Starfall from Convoke and it will still suggest you Starfall again. I have seen it also during the course of normal rotation or when not gaining Starfall from Convoke, but that is less rare and I have not been able to grab a Snapshot of it yet.
Expected behavior Should be suggesting Starsurge over Starfall in most cases.
Screenshots
The screenshot shows the Hekili recommendations in the two boxes to the left, The two boxes to the right are Weakauras showing current duration of Starfall and Eclipse.
WHEN SUBMITTING AN ISSUE:
PUT SNAPSHOT LINK HERE: