search

HelTecAutomation / CubeCell-Arduino

Heltec CubeCell Series (based on ASR6501, ASR6502 chip) Arduino support.
247 stars 138 forks source link

Stream.h : return value for read() should be "int" (not uint32) #62

Closed fredolaredo closed 4 years ago

fredolaredo commented 4 years ago

compared to other Arduino packages

./Heltec-esp32/hardware/esp32/0.0.4/cores/esp32/Stream.h virtual int read() = 0; ./Moteino/hardware/samd/1.3.0/cores/arduino/Stream.h virtual int read() = 0; ./esp32/hardware/esp32/1.0.4/cores/esp32/Stream.h virtual int read() = 0; ./arduino/hardware/avr/1.8.2/cores/arduino/Stream.h virtual int read() = 0; ./CubeCell/hardware/CubeCell/0.0.4/cores/asr650x/cores/Stream.h virtual uint32 read() = 0; ./industruino/hardware/samd/1.0.1/cores/industruino/Stream.h virtual int read() = 0;

fredolaredo commented 4 years ago

same for HardwareSerial.h

Heltec-Aaron-Lee commented 4 years ago

Thank you for your hints, I had updated it.