search

HelTecAutomation / CubeCell-Arduino

Heltec CubeCell Series (based on ASR6501, ASR6502 chip) Arduino support.
248 stars 137 forks source link

option architectures inconsistant in library.properties files #97

Open wasn-eu opened 4 years ago

wasn-eu commented 4 years ago

in the library.properties file the option architectures is inconsistant sometimesit is ASR650x-Arduino sometime CubeCell this should be fixed for the next release

lnlp commented 4 years ago

architecture=CubeCell is incorrect because CubeCell is not an MCU architecture but a product range.

architecture=ASR650x-Arduino is also incorrect. This is a valid name for the repository but is not the name of the MCU architecture. The architecture is ASR650x and the framework is Arduino. Using 'Arduino' in the architecture name is not only incorrect but is also a pleonasm. This is an Arduino core so it is all about Arduino (only). Adding '-Arduino' therefore makes no sense and is double.

The correct architecture is ASR650x, so architecture should be specified as:

architecture=ASR650x