search

HelanaNady / DataStructures

A beginner-friendly guide to learning data structures with C++
19 stars 3 forks source link

Linked list code #4

Closed AhmedAmrNabil closed 8 months ago

AhmedAmrNabil commented 8 months ago

added complete linked list code implementation in cpp with test main file fixed a typo in linkedlist.md note the code implementation of the linked list is a little different than the linkedlist.md

HelanaNady commented 8 months ago

it's great that you have also included an implementation in a cpp file, just for the sake of consistency can we align the copy constructor implementation to be similar?

we can also stick to insertFront and insertBack names instead of add in linkedlist.md, it did make things clearer

AhmedAmrNabil commented 8 months ago

it's great that you have also included an implementation in a cpp file, just for the sake of consistency can we align the copy constructor implementation to be similar?

I tried the code in the LinkedList.md file and that didn't work. Would you like me to try and fix that implementation or use the one currently implemented ?

habibayman commented 8 months ago

I appreciate you pointing that out. I have already identified the issue and made the necessary corrections.

Interestingly, I discovered that the mistake in the code was also present in the reference textbook . I have rectified it according to the correct implementation. I also tested it and it's now working perfectly fine.

The while loop's condition was reversed in addition to containing a logical error and a typo!