search

HelenFoster / AnkiSpreadsheetImportPlus

6 stars 1 forks source link

Implemented updated Anki API to address replacement of anki.importing #8

Closed CommanderPho closed 2 years ago

CommanderPho commented 2 years ago

Fixes errors on startup encountered (such as those depicted in the screenshot) with newer versions of Anki due to changes in the importing.Importers API.

2022-01-12 - Screenshot 17 14 04

Inspired by the fix Arthur Milchior implemented in his own addon at https://github.com/Arthur-Milchior/anki-import-anki1-files/commit/ce3a0ad4b3d280f197e50deea500d6a3ccda3600

The breaking change in Anki occurred here: https://github.com/ankitects/anki/commit/08ad9f33b998a9dd3677e925809aa169e45b8a01

For more information and discussion about the recent Anki API changes, see: https://forums.ankiweb.net/t/importer-code-changes-in-2-1-44-45-46/14080/2 https://github.com/ankitects/anki/pull/1543 https://github.com/ankitects/anki/commit/08ad9f33b998a9dd3677e925809aa169e45b8a01

HelenFoster commented 2 years ago

Thanks for figuring it out! I'll get to it as soon as I can.

HelenFoster commented 2 years ago

Looks like the breaking change was here: https://github.com/ankitects/anki/commit/efb1ce4 And though time-wise it was between 2.1.42 and 2.1.43, it was only merged for 2.1.45.