HelenaLC / CATALYST

Cytometry dATa anALYsis Tools
66 stars 30 forks source link

Is rowData and colData switched in the clustering part of the differential vignette? #387

Closed Sandyna closed 1 month ago

Sandyna commented 5 months ago

Both in the github vignette and in the Bioconductor vignette. Example pictures from the Bioconductor vignette seem to be flipped versions of the ones I get when I follow the vignette. In the code it's the other way around, which looks to be the correct way; rowData contains used_for_clustering and colData contains cluster_id. Is this a mistake, or am I not understanding something correctly?

HelenaLC commented 5 months ago

Ugh, apologies, this is indeed a typo - as for any SummarizedExperiment-derived class, SingleCellExperiments have rows = features and columns = parameters, here markers and cells, respectively. Thus, cell/observation metadata are colData, and marker/parameter metadata are rowData. I'll fix this with the next reasonable bug fix/version update; thank you for catching this after half a decade!

HelenaLC commented 1 month ago

Resolved on devel.