Open SamGG opened 2 weeks ago
Hi Helena, While adapting prepData() to convert my own object to sce and then using the CATALYST pipeline, I am usure about the need of this factor conversion https://github.com/HelenaLC/CATALYST/blob/4ff7b0284710e81dd598d0a9dedf3e463bb191c1/R/prepData.R#L291-L295 as md is reduced to the columns specified in md_cols and those columns previously converted to factor in https://github.com/HelenaLC/CATALYST/blob/4ff7b0284710e81dd598d0a9dedf3e463bb191c1/R/prepData.R#L231-L236 In the latter part, I am also unsure about the rename at L235.
Could you have a look when you have time and just drop me a line (without explanation) if you modify something or not. Best wishes, Samuel
Hi Helena, While adapting prepData() to convert my own object to sce and then using the CATALYST pipeline, I am usure about the need of this factor conversion https://github.com/HelenaLC/CATALYST/blob/4ff7b0284710e81dd598d0a9dedf3e463bb191c1/R/prepData.R#L291-L295 as md is reduced to the columns specified in md_cols and those columns previously converted to factor in https://github.com/HelenaLC/CATALYST/blob/4ff7b0284710e81dd598d0a9dedf3e463bb191c1/R/prepData.R#L231-L236 In the latter part, I am also unsure about the rename at L235.
Could you have a look when you have time and just drop me a line (without explanation) if you modify something or not. Best wishes, Samuel