HelenaLC / muscat

Multi-sample multi-group scRNA-seq analysis tools
166 stars 33 forks source link

When min_cells requirement is not satisfied for one group, that cluster_id is not tested #51

Open wmacnair opened 4 years ago

wmacnair commented 4 years ago

pbDS removes samples not satisfying min_cells / outliers requirements. The checks in pbDS.R:147-149 check that after these exclusions, it is still possible to fit the full model.

This means that where a cluster has many cells for most values of group_id, but is not present for one group_id, no model is fit for this cluster. Where clusters are strongly differentially abundant between conditions, this does happen in practice (in my data, this has resulted in ~25% of clusters returning no results, instead of returning partial results).

It should be possible to reduce the design matrix appropriately and rerun these checks, then run pbDS and add NA values for the excluded parameters.