HelfenKannJeder / come2help-web

Web-App: Project for recruiting and coordinating volunteer people.
http://come2.help/
GNU General Public License v3.0
4 stars 4 forks source link

Volunteer registration form with some tests #40

Closed vzickner closed 8 years ago

vzickner commented 8 years ago

This is a partial implementation of #20: After the OAuth 2.0 registration, it is necessary to save some user data. This pull request includes a form for user data and save them to the REST API. It is tested with the new protractor test behavior (see pull request #39 ).

Currently it is still work in progress:

jGleitz commented 8 years ago

Mocha tests have a fluent API. If you’d change the test descriptions, e.g. to

describe('Register Page', function() {
    it('has two entries: "Mocked Ability 1" and "Mocked Ability 2"', function() {
    });

    it('allows to register with correct data', function() {
    });

    it('shows an error for adult=false', function() {
    });
}); 

It’s very easy to read and we get a nice log, like:

Register Page
    ✓ has two entries: "Mocked Ability 1" and "Mocked Ability 2"
    ✓ allows to register with correct data
    ✓ shows an error for adult=false
vzickner commented 8 years ago

Any further comments on this pull request?