search

Helfima / helmod

Factorio Mod
156 stars 66 forks source link

Error on opening Pin Panel (0.12.6) #360

Closed KiwiHawk closed 2 years ago

KiwiHawk commented 3 years ago

image

Press pin button. Pin panel opens but does not show details. Error message:

Script @__helmod__/controller/DispatcherController.lua:74: __helmod__/gui/GuiElement.lua:131: bad argument #1 of 3 to 'concat' (table expected, got nil)

Issue does not occur in release version (0.12.5) but only in GitHub version.

I believe the issue was caused by commit 9fd0341c5cbe00c404c164d8eb0379d6178a6e45 changing gui\GuiCell.lua from

function GuiCell:mask(mask)
  self.m_mask = mask
  return self
end

to

function GuiCell:mask(mask)
  self.m_mask = mask
  return GuiCell
end

A similar change was made to gui\GuiSlider.lua

Helfima commented 2 years ago

fixed in v0.12.6