search

Helfima / helmod

Factorio Mod
156 stars 66 forks source link

Helmod loses output when it is a linked block, and the it is a fuel that is also used in the block. #366

Open Jemsterr opened 2 years ago

Jemsterr commented 2 years ago

Current game is AngelBobs + Clowns and Omni.

Trying to calculate fuel for the steam boilers, and found a reproducible bug creating the fuel.

In the attached save, if you change the fuel inputs for both the furnace and the boiler to the output fuel (in this case, omnified carbon) then the block doesn't see the fuel as an output.

As a workaround, you can unlink and hit the filter button, then manually add the required amount of omnified carbon for the output, but you can't have it as a linked block. image [Edit to clarify: in the screenshot above, this is just before the fuel was changed, if you change that purified omnite to omnified carbon (the black one with the purple thingy, as in the recipe above) then it loses the output.]

Save: ABCZ.zip

Jemsterr commented 2 years ago

Unrelated issue - that dropdown includes many items that have no fuel value, including many forms of omnicium (sheet coil, ingot, etc), omnifurnaces and soil. I added it here, instead of making a separate Issue, since the save file is here - unless I can link this save file from another issue?

KiwiHawk commented 2 years ago

Unrelated issue - that dropdown includes many items that have no fuel value, including many forms of omnicium (sheet coil, ingot, etc), omnifurnaces and soil. I added it here, instead of making a separate Issue, since the save file is here - unless I can link this save file from another issue?

The sheet coil, ingots etc have no fuel value. However they do have a fuel category. This should be nil. I've reported this on the Omni discord. I'll add a filter for fuel value > 0 to my PR.

KiwiHawk commented 2 years ago

In the attached save, if you change the fuel inputs for both the furnace and the boiler to the output fuel (in this case, omnified carbon) then the block doesn't see the fuel as an output.

I believe this is working as intended. By default, anything that is produced and consumed in the same block isn't linked.

To make it link, unfilter the output products and Ctrl + Click on Omnified Carbon. Output products can then be refiltered.

image