search

Helfima / helmod

Factorio Mod
149 stars 64 forks source link

Dialog scaled incorrectly #456

Closed KiwiHawk closed 12 months ago

KiwiHawk commented 1 year ago

Edit recipe dialog, factory section is being compressed too small with some Py recipes.

Use a machine that takes fuel and a recipe with at least five ingredients.

I found it specifcally for electric engine unit when the default assemling machine was set to burner assembling machine Mk2. That is an error in itself, because you cannot make electric engine units in burner assembly machines. But if burner assembly mk2 is default it wil set it anyway.

https://discord.com/channels/560199483065892894/1082163716952436746/1090691397776060466

image-1.png

image.png

espenst commented 1 year ago

Good. I found the error, and we talked on discord. Just contact me if you need any assistance.

espenst commented 1 year ago

Also found it for Tin-chromium alloy in a Smelter Mk1. It seems that factories with no module slots might be a problem. This also has just three ingredients.

image
KiwiHawk commented 1 year ago

@espenst Which version of Helmod are you using? I haven't been able to recreate the UI scaling issue.

The only way I have found to get Burner assembling machine MK 02 selected for the Electric engine unit recipe is to a different recipe that does support Burner machines and press the apply to block or apply to line buttons (">", ">>"). I've fixed this.

Adding a recipe line (e.g. Electric engine unit) that doesn't support Burner machines is not selecting an invalid machine. Not even if a burner assembly machine is set as default.

image image image

espenst commented 1 year ago

Sorry for the late reply. Vacations has started here, and I have been travelling today. I was using the latest helmod (0.12.15) on a 4K monitor running factorio in windowed full-screen mode if that can be related in any way.

I tested again today on my laptop (also 4K monitor, windowed factorio, full screen). Even though I set the recipe back to automated factory, it was today reverted to burner assembly. (This might be my default setting). When i opened the electric engine unit recipe, I could reproduce the error: image

These are my factorio settings: image image

Can the 200% UI scale cause this issue?

KiwiHawk commented 1 year ago

Yes! I was able to reproduce the issue by setting my UI scale to 150%. Thanks for the help!

image

Setting it to 200% actually works fine for me as it then splits over two tabs. This was a surprise to me!

image image

espenst commented 1 year ago

Happy to help. Thanks for working on this excellent mod. Great work!

Call out if I can be of any more assist

Helfima commented 1 year ago

I added a menu to switch in the next release, the default is automatic

image