Helfima / helmod

Factorio Mod
149 stars 64 forks source link

Recipe with loops in sub block not displaying correctly in parent block (Kovarex enrichment) #534

Open Paraplegix opened 1 month ago

Paraplegix commented 1 month ago

Probably related to the issue #511 Can be reproduced sortof with kovarex enrichment recipe in vanilla factorio, which is also a loop. Seems like the bug affects blocks when any of its output is also an output ? And AFAIK, Kovarex enrichment recipe is the only one that have that particularity in vanilla. Tested with latest GitHub version available

Sub block setup : Just kovarex enrichment, and request 10 U235. image

Parent block view : 0 value in the block. Expected the value of sub block to appear here image Comparing it with a block with no loop, like red circuit. It does show the value outputed by the sub block in the parent block

If I put any request number in the U235 request, parent block will display 10 (the value requested in the sub block) image Comparing it with a block with no loop, like red circuit. Putting any number doesn't change the value displayed, (and it was already correct).

Linking also behave weird From the same setup, and having a sub block with no input configured (clearing it), and requesting 10 U235 in parent block will stay at 0 with the block linked. Expected the sub block to be "configured" with 10 U235 request, thus having 30 u238 Ingredients/input. image doing the same with a similar setup but non looping recipe will show the product output/inputs as if it was configured inside the sub block

Configuring an amount in the sub block (2 in this example) will allow the parent block to show the correct amount (with 5 factories). I guess this is mostly what is expected. (IMHO still not convinced by it not overriding any value in sub block) image

Production line data (should be same as third screenshot ?) : ``` eNrtV8lu2zAQ/ZVAZ8aQ4iUBAl566K1AkWtRCJQ0dlhTokCRrg1D/97hJkuOUzRO21N8sTgU32yPj1Qlb4QsmbjJ6bEUrOto8kVWIBLCK5rU9jG/T4j82YCiyVemWCtgw/cJKXDdNse35uFRSakHkE/W5EH8bIaDpoI9TUnDaqDJVu6Ygv0tNIqXzzU0+rZVsoSuu+iulKbRNCOt/IlTd9l96n4IulFQcVze0eO3xCjWcFPf3s2XyXd69K7GRqIPLZq4hjohrHaoKek000DTnowRHi4hPFxEmEeIu74nmEZlynfEk9m0WqPpMqBmVwc2jqt85qJS0NCjb8n89W7N39It71ZByVv46F3sXZb+o+Y9nfr2FGpuG/f0jp6VMfSQPpcNtmvNSi3VYfD22Y+TAF8ioOJrs4EIhwauD0P4q5QAcmFzoPNVtlrdk64FqBBY8Jrb7FBejACsdU9gvQZXdv/OKZIdIuKwlE1n6tZFhpNSCOOfsTKsvWaZW5FrqZlw1BymZunq7JeFPMLbkcCnRWFiEQq5SlP/lPtMT+MKoLXDnhTAbHD0OOxBZ4jFLcLoYmGHui4eXBylrAuJ3ltQeWxaOluOx7l1ppml+8Xyj/MLwdJpEpMUUmRkwTrINcdoM+L+VuOKhFAXr5RujJxNoC0Lz3TCjcPL51a3ZmyMfVyMo/FrJya30Fpwj6Dvifa1fGfPsvGWfLn7eysXY3emEbzZIg21MkCKw9CLNRMdvHSER2Io3zPrcq8abqksfoDlMFySoS0czlRox4RBFNuTSVmvqtvvSoVbqWZWEAqDYoTq7ZgdByOyD6bI96Al3GZ00o2og68ryVv3U0S8vH3+jNZxY/ajDdJPGEpg3zKU2ooeT8ec73I/ldDriDRiynADmwr2X+TN8oM2/4s2LyShk2KHSheY41ShO93OMLzJDaknCjppVOk1O3AAATpPNn/6zy19MBuNdnq8/ly13izZ/BXfswwzegyfC/i90D/mMx/zLIYcDO5bYBavLHH2UYE2qrnJH6GpfgH9U2vF ```

Recipe that have a "loop" are rare in vanilla, but in modded it's quite frequent (Pyanodon :eyes:)