Helfima / helmod

Factorio Mod
149 stars 64 forks source link

Calculates blocks with multiple outputs incorrectly, multi linked product #538

Open Helfima opened 1 week ago

Helfima commented 1 week ago

source: https://mods.factorio.com/mod/helmod/discussion/66706c14798929619e062027

Helmod 1.0.11 calculates blocks with multiple outputs incorrectly

Screenshots with problem description https://imgur.com/a/helmod-1-0-11-multiple-output-bug-HCn60Cm

Let's say I have 2 blocks, the top one demands 1.66 sheet and 0.17 rods Suppose I add a second block with just these 2 ingredients (completely independent). In that case, Helmod sets production of both ingredients TO MATCH EXACT VALUE of the one chosen as the main ingredient (see screenshot). So it will either be

  • 0.17 sheet and 0.17 rods
  • 1.66 sheet and 1.66 rods

Expected behavior: linked production block should satisfy the production of both ingredients independently

  • 1.66 sheet and 0.17 rods

Workaround:

  • create 2 blocks instead of one, each with 1 ingredient. (But for mods like Nulius that's a disaster, you have to group not to get drowned in the planner).

Save where you can see the problem (open the only plan, it will have exact these blocks) https://drive.google.com/file/d/1n8gm3iRz3XfTU7A6_N39WUZI7DY8rbOO/view

Versions

  • Factorio 1.1.107
  • Helmod 1.0.11
  • Nulius (not sure it is important, but) 1.9.1

P.S. Amazing work on 1.X! I was sceptical at first, but when I got, can't stop using this "tree-like" structure!

Try the same second block, but add 3 recipies

  • aluminum rod box (demand = 0.2)
  • aluminum sheet bot (demand = 1.7)
  • AND aluminum wire box (demand = 1.5)

Expectation: production should match demand on all 3 recipes

Reality: Adding 3rd recipe makes wire box being OVERPRODUCED which leads to increased production of rods

Please check the screenshots below and you can reproduce it on the same save file https://imgur.com/a/factorio-helmod-1-0-11-bug-1HadKyx

Paraplegix commented 1 week ago

Similar to #537 ?