Implement the Poynting vector calculation

HelgeGehring / femwell

FEM mode solver for photonic waveguides

https://helgegehring.github.io/femwell/

GNU General Public License v3.0

104 stars 30 forks source link

Closed lucasgrjn closed 6 months ago

lucasgrjn commented 8 months ago

Regarding the issue #106:

Implement the function calculate_poynting() for the class Mode() to calculate the Poynting vector of a mode
Improve the docs by adding the graph Fig.1.h et Fig.1.f from the article used in the effective_area example.

HelgeGehring commented 8 months ago

Looks amazing!

Two small ideas:

we might want to use the discontinuous variant of the element we use for Ez, that would probably allow higher accuracy in case we use a higher order and also quad meshes? (Instead of hardcoding ElementTriP1)
what about having it as a cached property instead? Once calculated there's no need to calculate it again?

What do you think?

lucasgrjn commented 8 months ago

Thanks for the comments/ideas :)

I was able to gather the element used from Ez but my knowledges on discontinuous element / mesh / quadrature remain really limited actually, so I really appreciate your insight!
For the cached_property, it definitely make sense. I started like this but I switched to a normal function because of the poynting basis. But returns the basis + the property seems a good way! (I also add Px, Py and Pz as properties of Mode).